From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B7FDC433E2 for ; Thu, 17 Sep 2020 18:33:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B17D9206CA for ; Thu, 17 Sep 2020 18:33:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726419AbgIQSdV (ORCPT ); Thu, 17 Sep 2020 14:33:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726448AbgIQScU (ORCPT ); Thu, 17 Sep 2020 14:32:20 -0400 Received: from saturn.retrosnub.co.uk (saturn.retrosnub.co.uk [IPv6:2a00:1098:86::1:1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67F5BC06174A; Thu, 17 Sep 2020 11:32:19 -0700 (PDT) Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) by saturn.retrosnub.co.uk (Postfix; Retrosnub mail submission) with ESMTPSA id 44C509E016A; Thu, 17 Sep 2020 19:32:08 +0100 (BST) Date: Thu, 17 Sep 2020 19:32:06 +0100 From: Jonathan Cameron To: Bartosz Golaszewski Cc: Lee Jones , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , arm-soc , LKML , linux-iio , Marc Zyngier Subject: Re: [PATCH 15/30] iio: dummy: iio_dummy_evgen: Demote file header and supply description for 'irq_sim_domain' Message-ID: <20200917193206.40f68d76@archlinux> In-Reply-To: <20200718160046.5d1c8abb@archlinux> References: <20200716135928.1456727-1-lee.jones@linaro.org> <20200716135928.1456727-16-lee.jones@linaro.org> <20200718160046.5d1c8abb@archlinux> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 18 Jul 2020 16:00:46 +0100 Jonathan Cameron wrote: > On Sat, 18 Jul 2020 11:24:40 +0200 > Bartosz Golaszewski wrote: > > > On Thu, Jul 16, 2020 at 3:59 PM Lee Jones wrote: > > > > > > File headers are not good candidates for kerneldoc. > > > > > > Fixes the following W=1 kernel build warning(s): > > > > > > drivers/iio/dummy/iio_dummy_evgen.c:30: warning: Cannot understand * @regs: irq regs we are faking > > > on line 30 - I thought it was a doc line > > > drivers/iio/dummy/iio_dummy_evgen.c:42: warning: Function parameter or member 'irq_sim_domain' not described in 'iio_dummy_eventgen' > > > > > > Cc: Marc Zyngier > > > Cc: Bartosz Golaszewski > > > Signed-off-by: Lee Jones > > > --- > > > drivers/iio/dummy/iio_dummy_evgen.c | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/iio/dummy/iio_dummy_evgen.c b/drivers/iio/dummy/iio_dummy_evgen.c > > > index ee85d596e5284..1febbbff0ded6 100644 > > > --- a/drivers/iio/dummy/iio_dummy_evgen.c > > > +++ b/drivers/iio/dummy/iio_dummy_evgen.c > > > @@ -1,5 +1,5 @@ > > > // SPDX-License-Identifier: GPL-2.0-only > > > -/** > > > +/* > > > * Copyright (c) 2011 Jonathan Cameron > > > * > > > * Companion module to the iio simple dummy example driver. > > > @@ -27,11 +27,13 @@ > > > #define IIO_EVENTGEN_NO 10 > > > > > > /** > > > + * struct iio_dummy_eventgen > > Good to say what this structure is. Perhaps "event generator specific state" > > > > * @regs: irq regs we are faking > > > * @lock: protect the evgen state > > > * @inuse: mask of which irqs are connected > > > * @irq_sim: interrupt simulator > > > * @base: base of irq range > > > + * @irq_sim_domain: irq domain > > > > To be even more clear: this could say: "interrupt simulator domain". > > > > Bartosz Tweaked during applying and applied. > > > > > */ > > > struct iio_dummy_eventgen { > > > struct iio_dummy_regs regs[IIO_EVENTGEN_NO]; > > > -- > > > 2.25.1 > > > >