* [PATCH] platform/x86: fix kconfig dependency warning for LG_LAPTOP
@ 2020-09-15 9:09 Necip Fazil Yildiran
2020-09-17 12:16 ` Hans de Goede
2020-09-17 21:51 ` mark gross
0 siblings, 2 replies; 3+ messages in thread
From: Necip Fazil Yildiran @ 2020-09-15 9:09 UTC (permalink / raw)
To: andy
Cc: matan, platform-driver-x86, linux-kernel, paul, jeho,
Necip Fazil Yildiran
When LG_LAPTOP is enabled and NEW_LEDS is disabled, it results in the
following Kbuild warning:
WARNING: unmet direct dependencies detected for LEDS_CLASS
Depends on [n]: NEW_LEDS [=n]
Selected by [y]:
- LG_LAPTOP [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y] && ACPI [=y] && ACPI_WMI [=y] && INPUT [=y]
The reason is that LG_LAPTOP selects LEDS_CLASS without depending on or
selecting NEW_LEDS while LEDS_CLASS is subordinate to NEW_LEDS.
Honor the kconfig menu hierarchy to remove kconfig dependency warnings.
Fixes: dbf0c5a6b1f8 ("platform/x86: Add LG Gram laptop special features driver")
Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>
---
drivers/platform/x86/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 40219bba6801..81f6079d08e6 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -1112,6 +1112,7 @@ config LG_LAPTOP
depends on ACPI_WMI
depends on INPUT
select INPUT_SPARSEKMAP
+ select NEW_LEDS
select LEDS_CLASS
help
This driver adds support for hotkeys as well as control of keyboard
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] platform/x86: fix kconfig dependency warning for LG_LAPTOP
2020-09-15 9:09 [PATCH] platform/x86: fix kconfig dependency warning for LG_LAPTOP Necip Fazil Yildiran
@ 2020-09-17 12:16 ` Hans de Goede
2020-09-17 21:51 ` mark gross
1 sibling, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2020-09-17 12:16 UTC (permalink / raw)
To: Necip Fazil Yildiran, andy
Cc: matan, platform-driver-x86, linux-kernel, paul, jeho
Hi,
On 9/15/20 11:09 AM, Necip Fazil Yildiran wrote:
> When LG_LAPTOP is enabled and NEW_LEDS is disabled, it results in the
> following Kbuild warning:
>
> WARNING: unmet direct dependencies detected for LEDS_CLASS
> Depends on [n]: NEW_LEDS [=n]
> Selected by [y]:
> - LG_LAPTOP [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y] && ACPI [=y] && ACPI_WMI [=y] && INPUT [=y]
>
> The reason is that LG_LAPTOP selects LEDS_CLASS without depending on or
> selecting NEW_LEDS while LEDS_CLASS is subordinate to NEW_LEDS.
>
> Honor the kconfig menu hierarchy to remove kconfig dependency warnings.
>
> Fixes: dbf0c5a6b1f8 ("platform/x86: Add LG Gram laptop special features driver")
> Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>
Thnak you, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Note it seems that the FUJITSU_LAPTOP Kconfig symbol has the same
issue, can you submit a patch for that one too?
Regards,
Hans
> ---
> drivers/platform/x86/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 40219bba6801..81f6079d08e6 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1112,6 +1112,7 @@ config LG_LAPTOP
> depends on ACPI_WMI
> depends on INPUT
> select INPUT_SPARSEKMAP
> + select NEW_LEDS
> select LEDS_CLASS
> help
> This driver adds support for hotkeys as well as control of keyboard
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] platform/x86: fix kconfig dependency warning for LG_LAPTOP
2020-09-15 9:09 [PATCH] platform/x86: fix kconfig dependency warning for LG_LAPTOP Necip Fazil Yildiran
2020-09-17 12:16 ` Hans de Goede
@ 2020-09-17 21:51 ` mark gross
1 sibling, 0 replies; 3+ messages in thread
From: mark gross @ 2020-09-17 21:51 UTC (permalink / raw)
To: Necip Fazil Yildiran
Cc: andy, matan, platform-driver-x86, linux-kernel, paul, jeho
Acked-by: mark gross <mgross@linux.intel.com>
--mark
On Tue, Sep 15, 2020 at 12:09:23PM +0300, Necip Fazil Yildiran wrote:
> When LG_LAPTOP is enabled and NEW_LEDS is disabled, it results in the
> following Kbuild warning:
>
> WARNING: unmet direct dependencies detected for LEDS_CLASS
> Depends on [n]: NEW_LEDS [=n]
> Selected by [y]:
> - LG_LAPTOP [=y] && X86 [=y] && X86_PLATFORM_DEVICES [=y] && ACPI [=y] && ACPI_WMI [=y] && INPUT [=y]
>
> The reason is that LG_LAPTOP selects LEDS_CLASS without depending on or
> selecting NEW_LEDS while LEDS_CLASS is subordinate to NEW_LEDS.
>
> Honor the kconfig menu hierarchy to remove kconfig dependency warnings.
>
> Fixes: dbf0c5a6b1f8 ("platform/x86: Add LG Gram laptop special features driver")
> Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>
> ---
> drivers/platform/x86/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 40219bba6801..81f6079d08e6 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1112,6 +1112,7 @@ config LG_LAPTOP
> depends on ACPI_WMI
> depends on INPUT
> select INPUT_SPARSEKMAP
> + select NEW_LEDS
> select LEDS_CLASS
> help
> This driver adds support for hotkeys as well as control of keyboard
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-17 21:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-15 9:09 [PATCH] platform/x86: fix kconfig dependency warning for LG_LAPTOP Necip Fazil Yildiran
2020-09-17 12:16 ` Hans de Goede
2020-09-17 21:51 ` mark gross
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).