From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7B45C43464 for ; Thu, 17 Sep 2020 22:35:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7F7A020707 for ; Thu, 17 Sep 2020 22:35:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=nic.cz header.i=@nic.cz header.b="czD/G+gh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726723AbgIQWfh (ORCPT ); Thu, 17 Sep 2020 18:35:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726299AbgIQWeM (ORCPT ); Thu, 17 Sep 2020 18:34:12 -0400 Received: from mail.nic.cz (lists.nic.cz [IPv6:2001:1488:800:400::400]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA6FFC06174A; Thu, 17 Sep 2020 15:34:02 -0700 (PDT) Received: from dellmb.labs.office.nic.cz (unknown [IPv6:2001:1488:fffe:6:cac7:3539:7f1f:463]) by mail.nic.cz (Postfix) with ESMTP id 9B397142056; Fri, 18 Sep 2020 00:33:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nic.cz; s=default; t=1600382039; bh=LQAKDx0kVA7SocOtXLCSbyuMWmlZJ0E/+Mbf5ZWeZ6A=; h=From:To:Date; b=czD/G+ghQUntUJou8dAIiozCvmmm6cxDH6NHBFTGhZwsqQ3OTJHuTWMhw9c6kG+8Z XReDwu6v4rqng9/klbj9rrKEaqlV6HFXI/O9BO9dnrFbH5i31efxjEdAC6NjLWG3iC +Uv+0yz3FOlirYZZdYUguFn5APKQk3o5/dcWCRuY= From: =?UTF-8?q?Marek=20Beh=C3=BAn?= To: linux-leds@vger.kernel.org Cc: Pavel Machek , Dan Murphy , =?UTF-8?q?Ond=C5=99ej=20Jirman?= , linux-kernel@vger.kernel.org, Rob Herring , devicetree@vger.kernel.org, =?UTF-8?q?Marek=20Beh=C3=BAn?= Subject: [PATCH leds v2 35/50] leds: lm36274: do not set chip settings in DT parsing function Date: Fri, 18 Sep 2020 00:33:23 +0200 Message-Id: <20200917223338.14164-36-marek.behun@nic.cz> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200917223338.14164-1-marek.behun@nic.cz> References: <20200917223338.14164-1-marek.behun@nic.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spamd-Bar: / X-Virus-Scanned: clamav-milter 0.102.2 at mail X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org These settings are not parsed from DT and therefore semantically should not be set in function with a name lm36274_parse_dt. Signed-off-by: Marek Behún Cc: Dan Murphy --- drivers/leds/leds-lm36274.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/leds/leds-lm36274.c b/drivers/leds/leds-lm36274.c index 294edcc054bea..b61c97ed26603 100644 --- a/drivers/leds/leds-lm36274.c +++ b/drivers/leds/leds-lm36274.c @@ -100,14 +100,6 @@ static int lm36274_parse_dt(struct lm36274 *chip, fwnode_property_read_string(child, "linux,default-trigger", &chip->led_dev.default_trigger); - chip->lmu_data.regmap = chip->regmap; - chip->lmu_data.max_brightness = MAX_BRIGHTNESS_11BIT; - chip->lmu_data.msb_brightness_reg = LM36274_REG_BRT_MSB; - chip->lmu_data.lsb_brightness_reg = LM36274_REG_BRT_LSB; - - chip->led_dev.max_brightness = MAX_BRIGHTNESS_11BIT; - chip->led_dev.brightness_set_blocking = lm36274_brightness_set; - return 0; err: fwnode_handle_put(child); @@ -142,6 +134,14 @@ static int lm36274_probe(struct platform_device *pdev) return ret; } + chip->lmu_data.regmap = chip->regmap; + chip->lmu_data.max_brightness = MAX_BRIGHTNESS_11BIT; + chip->lmu_data.msb_brightness_reg = LM36274_REG_BRT_MSB; + chip->lmu_data.lsb_brightness_reg = LM36274_REG_BRT_LSB; + + chip->led_dev.max_brightness = MAX_BRIGHTNESS_11BIT; + chip->led_dev.brightness_set_blocking = lm36274_brightness_set; + ret = devm_led_classdev_register_ext(chip->dev, &chip->led_dev, &init_data); if (ret) -- 2.26.2