From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3456C43466 for ; Fri, 18 Sep 2020 10:04:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A945421D7B for ; Fri, 18 Sep 2020 10:04:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600423462; bh=rHX2SJofq2IV2gFxJYFKOzylhVaYmIes7RqnZSio3jI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Os2XS71RFhlPup2Z1G1bTZ8+9r4z9K+hAELcnW90rlXNUFMrlNlJZYHQ2Kx5vIXDz vcpo4Wx0w4qdyTNg4JZYLPOxRKIEilnPv01DXx1vx6uMBgt7jYbiyAhdLoiXMT491Z KnCMK1sfh9popXdevS7wj9Aj2FmlAksSOm0W93uU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726241AbgIRKEW (ORCPT ); Fri, 18 Sep 2020 06:04:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:50364 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725941AbgIRKEV (ORCPT ); Fri, 18 Sep 2020 06:04:21 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4627F208B8; Fri, 18 Sep 2020 10:04:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600423460; bh=rHX2SJofq2IV2gFxJYFKOzylhVaYmIes7RqnZSio3jI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kG8rJC4Cp3hvPot3IGhEDxr/XcztZKD0zBEoAcGY/UDvmDIIJspf24TsdjkIGywuC zSbCqfERK3B448QOXLpaLB45J6Tl3VodqOmJvcVMwMEsg5OO6S6oEzLyXS/PNKoz0l wPU+1g6T84vkWW85jwFPbT0tY9oOlsmRulj+eVfQ= Date: Fri, 18 Sep 2020 11:03:30 +0100 From: Mark Brown To: Guenter Roeck Cc: Alban Bedel , linux-hwmon@vger.kernel.org, Jean Delvare , Rob Herring , Liam Girdwood , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] hwmon: (lm75) Add regulator support Message-ID: <20200918100330.GA5703@sirena.org.uk> References: <20200917101819.32045-1-alban.bedel@aerq.com> <20200917101819.32045-4-alban.bedel@aerq.com> <20200917110053.GA4755@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fdj2RfSjLxBAspz7" Content-Disposition: inline In-Reply-To: X-Cookie: Beware of geeks bearing graft. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --fdj2RfSjLxBAspz7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Sep 17, 2020 at 07:04:51PM -0700, Guenter Roeck wrote: > On 9/17/20 4:00 AM, Mark Brown wrote: > > On Thu, Sep 17, 2020 at 12:18:19PM +0200, Alban Bedel wrote: > >> + data->vs = devm_regulator_get_optional(dev, "vs"); > >> + if (IS_ERR(data->vs)) { > > Unless the device can work without power you should not be using > > regulator_get_optional(). > The driver works today without regulator, and needs to continue > doing so. And it will continue to do so if it uses the normal regulator API, it will as ever ensure that if no regulator is provided by the firmware a dummy is provided. --fdj2RfSjLxBAspz7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl9khfEACgkQJNaLcl1U h9Bepwf9EYuxEZIeHPaK2Y0tAjFZp9YXlbTfjm444mUIeGVycPVpixaad4WmaFfx GwhiOO9mbYjzskCaeTjuY365KEofDOqY68qR1D1PmX0inyYE6WQfS+gYhDaS/JFd LKLOM6oSst+LamCt4GljU5hPd8khylSGriDqAZey/HArmFsjiMjf/P/+kHoe6NHy hhDqj2FY47DZq5OfJgHnOHGWZckVlJhzprcBhXJI1fbgzsWrwN/D0yDdBNj2c6LE P3fPIoM4nTZCfBLydMrMoDDeSmhYb7xAeMFeeaXAVUAfbo6JJjOXb1FySeThLvAv H+r0E+jRWuNtHjjSZli7ckZzBOZ0eQ== =dCm7 -----END PGP SIGNATURE----- --fdj2RfSjLxBAspz7--