From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E9A0C43466 for ; Fri, 18 Sep 2020 10:05:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 305252075E for ; Fri, 18 Sep 2020 10:05:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600423533; bh=h0lkuxqUPtrrUnI9EjvXQhkOT9wfxsfGvLGrRfcRWpw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=fS5cfrdZ+qgFxgZbW6X7ISaYTGWOFfjGvN6v/sKXrtT5YaDOU250BLMbeMCdr5e2C UhMRrYH+RKc3wGoyQHH/EJZIOjYAR+7JFZhm9H7pQ+635zXFnOJLSKxar8wy1wMLgz KoArjT0QFg/U/XFgnkqptRs/phodUztOgQhUCvAw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726437AbgIRKFc (ORCPT ); Fri, 18 Sep 2020 06:05:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:50712 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725874AbgIRKFb (ORCPT ); Fri, 18 Sep 2020 06:05:31 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C487520665; Fri, 18 Sep 2020 10:05:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600423531; bh=h0lkuxqUPtrrUnI9EjvXQhkOT9wfxsfGvLGrRfcRWpw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bHddCIFCZn4+sdX5R0OHIYUPadPzF8mhaCWTel5RLNX1E0Row0SILO/lOvsav2PCO 8lc0l0iFGenegjZeJyefH34rt6vrt7hwHMimIz1+tXzsggxE6OsLuf4nfV+aRo639+ Tb4MRuZx6/tMbSOv9EQ7X/TY2wR3ZrF3p02ZI6Js= Date: Fri, 18 Sep 2020 11:04:40 +0100 From: Mark Brown To: Guenter Roeck Cc: Alban Bedel , linux-hwmon@vger.kernel.org, Jean Delvare , Rob Herring , Liam Girdwood , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] hwmon: (lm75) Add regulator support Message-ID: <20200918100440.GB5703@sirena.org.uk> References: <20200917101819.32045-1-alban.bedel@aerq.com> <20200917101819.32045-4-alban.bedel@aerq.com> <7986c014-b826-bad1-f19c-cdda31d20804@roeck-us.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="0eh6TmSyL6TZE2Uz" Content-Disposition: inline In-Reply-To: <7986c014-b826-bad1-f19c-cdda31d20804@roeck-us.net> X-Cookie: Beware of geeks bearing graft. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --0eh6TmSyL6TZE2Uz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Sep 17, 2020 at 10:33:37PM -0700, Guenter Roeck wrote: > On 9/17/20 3:18 AM, Alban Bedel wrote: > > + err = regulator_enable(data->vs); > How about device removal ? Don't you have to call regulator_disable() > there as well ? If so, it might be best to use devm_add_action_or_reset() > to register a disable function. Yes, disables should be balanced (and any attempt to unregister the regulator with references still held should result in a warning). --0eh6TmSyL6TZE2Uz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl9khjgACgkQJNaLcl1U h9AdDAf/YNuWEsjoIefRmZlEaEFDrFOFf++WJDvAcSCC0fP0VeoLuRhuNjHGdYDM jmwCuCSjeb0sX74vrLNmK6/SIsny3ffxorGP+OVo2mluxO8VRnLQT/DkgXiZ6eAH 1Tk7/v3jzHDyeRNvXEnGmGTq4BqmSa7LgOozSOJkVWuJvfPDJQyipK4/bYF+taN0 c5I8179rpeBwQXFfT5SywLx1G2MIxg7TfgmBqdftTnc7+dLlJ94iN7twLoprtYt4 ujfCjaEM2+Bq3EZgIFBzIWW+j2x79l95Tm0JGPqVog4c72At13ZjgWdvBQknHzIT H7hOtmKbybGcenxIEVbo/ebAD8H/3A== =n9tP -----END PGP SIGNATURE----- --0eh6TmSyL6TZE2Uz--