From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A6F0C43465 for ; Fri, 18 Sep 2020 12:42:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 30F17208B8 for ; Fri, 18 Sep 2020 12:42:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="XJthRxMj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726549AbgIRMmJ (ORCPT ); Fri, 18 Sep 2020 08:42:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726455AbgIRMmI (ORCPT ); Fri, 18 Sep 2020 08:42:08 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6A7EC061756 for ; Fri, 18 Sep 2020 05:42:07 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id c18so5473466wrm.9 for ; Fri, 18 Sep 2020 05:42:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=SOcYopzpVA91Ur8JOndAUuW5kC5KQpU+aqaU8ciX7/I=; b=XJthRxMj7p5FVQ8UB8QHPjpkyrZ1DYRAiW2zVjRAhJUW0e0QzTxX9S0LywyZSJEGAX oQ6rcMf41/DYJXO67/Xq8aoMk84qRFYHTNdeA/7L9sScQbt/SEfZaJSlI5KxMxxR+CIT M/6Aec09cMTtIOtfSD5s3TkOo40GHFODxElv0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=SOcYopzpVA91Ur8JOndAUuW5kC5KQpU+aqaU8ciX7/I=; b=hSPL2yiK/w/E2KOMkYYXI3M/cwzzrYP8d7Yrov05z0M7jVKvlLyLXUiFr2WeI8/kyH J95XKSXTjhePcaZvJHXzCD3rZ3qP3ZVfnjwR3wJ2VQ/5l5utKMRnS1haEklY7af8H1/D +L2him7ZRER3pnX1KwezishatepST0/taZEdGok3QHiKx8+WBuZm0c/BH/rYg8Fi8o1f LaiQAsGrzQsc9zRtNDnHeJxPMuUojMskTgWhDkkv0mdW+30boQkn4cRm5/1tmddqZ7Lt tfXbrQ65VTWFPCVs/L37Li6pWQ0Ybi+SR/u4APIXk5mpBrbtGTdzHiqcIiYfuR27BI4s gemQ== X-Gm-Message-State: AOAM5338EzDViy4l5CgrhNoXUcs075A04If3xVYBaxIZvmcfBZwS7XqO zqSIVl4/KX8z7wYUshYSOxl8bw== X-Google-Smtp-Source: ABdhPJzrTC3CW6AB1dTSGBrjqUS3H6j44ck9bWQgvGGmKSFb26qrBxqU+OHgoRbREA252KDgVlNEww== X-Received: by 2002:a5d:4a49:: with SMTP id v9mr41100529wrs.153.1600432926218; Fri, 18 Sep 2020 05:42:06 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id d2sm5156057wro.34.2020.09.18.05.42.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Sep 2020 05:42:05 -0700 (PDT) Date: Fri, 18 Sep 2020 14:42:03 +0200 From: Daniel Vetter To: Vaibhav Gupta Cc: Bjorn Helgaas , Bjorn Helgaas , Bjorn Helgaas , Vaibhav Gupta , Bartlomiej Zolnierkiewicz , Sam Ravnborg , Paul Mackerras , Russell King , Andres Salomon , Antonino Daplas , linux-fbdev@vger.kernel.org, kernel test robot , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-geode@lists.infradead.org, linux-kernel-mentees@lists.linuxfoundation.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v1] fbdev: aty: remove CONFIG_PM container Message-ID: <20200918124203.GY438822@phenom.ffwll.local> Mail-Followup-To: Vaibhav Gupta , Bjorn Helgaas , Bjorn Helgaas , Bjorn Helgaas , Vaibhav Gupta , Bartlomiej Zolnierkiewicz , Sam Ravnborg , Paul Mackerras , Russell King , Andres Salomon , Antonino Daplas , linux-fbdev@vger.kernel.org, kernel test robot , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-geode@lists.infradead.org, linux-kernel-mentees@lists.linuxfoundation.org, linux-arm-kernel@lists.infradead.org References: <20200917115313.725622-1-vaibhavgupta40@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200917115313.725622-1-vaibhavgupta40@gmail.com> X-Operating-System: Linux phenom 5.7.0-1-amd64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 17, 2020 at 05:23:14PM +0530, Vaibhav Gupta wrote: > The changes made in below mentioned commit removed CONFIG_PM containers > from drivers/video/fbdev/aty/atyfb_base.c but not from > drivers/video/fbdev/aty/atyfb.h for respective callbacks. > > This resulted in error for implicit declaration for those callbacks. > > Fixes: 348b2956d5e6 ("fbdev: aty: use generic power management") > > Signed-off-by: Vaibhav Gupta > Reported-by: kernel test robot Applied, thanks. -Daniel > --- > drivers/video/fbdev/aty/atyfb.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/fbdev/aty/atyfb.h b/drivers/video/fbdev/aty/atyfb.h > index a7833bc98225..551372f9b9aa 100644 > --- a/drivers/video/fbdev/aty/atyfb.h > +++ b/drivers/video/fbdev/aty/atyfb.h > @@ -287,8 +287,8 @@ static inline void aty_st_8(int regindex, u8 val, const struct atyfb_par *par) > #endif > } > > -#if defined(CONFIG_PM) || defined(CONFIG_PMAC_BACKLIGHT) || \ > -defined (CONFIG_FB_ATY_GENERIC_LCD) || defined (CONFIG_FB_ATY_BACKLIGHT) > +#if defined(CONFIG_PMAC_BACKLIGHT) || defined (CONFIG_FB_ATY_GENERIC_LCD) || \ > +defined (CONFIG_FB_ATY_BACKLIGHT) > extern void aty_st_lcd(int index, u32 val, const struct atyfb_par *par); > extern u32 aty_ld_lcd(int index, const struct atyfb_par *par); > #endif > -- > 2.28.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch