From: Daniel Vetter <daniel@ffwll.ch>
To: Jing Xiangfeng <jingxiangfeng@huawei.com>
Cc: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
b.zolnierkie@samsung.com, gregkh@linuxfoundation.org,
daniel.vetter@ffwll.ch, jirislaby@kernel.org,
ndesaulniers@google.com, natechancellor@gmail.com,
george.kennedy@oracle.com, peda@axentia.se,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fbcon: Remove the superfluous break
Date: Fri, 18 Sep 2020 14:43:46 +0200 [thread overview]
Message-ID: <20200918124346.GZ438822@phenom.ffwll.local> (raw)
In-Reply-To: <5F6404B2.3080602@huawei.com>
On Fri, Sep 18, 2020 at 08:52:02AM +0800, Jing Xiangfeng wrote:
>
>
> On 2020/9/18 2:52, Gustavo A. R. Silva wrote:
> >
> >
> > On 9/17/20 08:15, Jing Xiangfeng wrote:
> > > Remove the superfuous break, as there is a 'return' before it.
> > >
> > > Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
> >
> > Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> >
> > Also, the following Fixes tag should be included in the changelog text:
> >
> > Fixes: bad07ff74c32 ("fbcon: smart blitter usage for scrolling")
>
> OK, I'll send a v2 with this tag.
Please also collect all the r-b tags you received so I can just apply
everything.
-Daniel
>
> >
> > Thanks
> > --
> > Gustavo
> >
> > > ---
> > > drivers/video/fbdev/core/fbcon.c | 2 --
> > > 1 file changed, 2 deletions(-)
> > >
> > > diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
> > > index 0b49b0f44edf..623359aadd1e 100644
> > > --- a/drivers/video/fbdev/core/fbcon.c
> > > +++ b/drivers/video/fbdev/core/fbcon.c
> > > @@ -1727,7 +1727,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b,
> > > vc->vc_video_erase_char,
> > > vc->vc_size_row * count);
> > > return true;
> > > - break;
> > >
> > > case SCROLL_WRAP_MOVE:
> > > if (b - t - count > 3 * vc->vc_rows >> 2) {
> > > @@ -1818,7 +1817,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b,
> > > vc->vc_video_erase_char,
> > > vc->vc_size_row * count);
> > > return true;
> > > - break;
> > >
> > > case SCROLL_WRAP_MOVE:
> > > if (b - t - count > 3 * vc->vc_rows >> 2) {
> > >
> > .
> >
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
prev parent reply other threads:[~2020-09-18 12:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 13:15 [PATCH] fbcon: Remove the superfluous break Jing Xiangfeng
2020-09-17 17:36 ` Nick Desaulniers
2020-09-18 0:50 ` Jing Xiangfeng
2020-09-17 18:52 ` Gustavo A. R. Silva
2020-09-18 0:52 ` Jing Xiangfeng
2020-09-18 12:43 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200918124346.GZ438822@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=b.zolnierkie@samsung.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=george.kennedy@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo@embeddedor.com \
--cc=jingxiangfeng@huawei.com \
--cc=jirislaby@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=peda@axentia.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).