From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02D73C43465 for ; Fri, 18 Sep 2020 14:21:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B391523719 for ; Fri, 18 Sep 2020 14:21:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="hT7P6Ohd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726698AbgIROVB (ORCPT ); Fri, 18 Sep 2020 10:21:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726130AbgIROVA (ORCPT ); Fri, 18 Sep 2020 10:21:00 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61F40C0613CE; Fri, 18 Sep 2020 07:21:00 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D1A3E2D7; Fri, 18 Sep 2020 16:20:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1600438859; bh=EGDu4Odiz5OdsLwDuo0oZsSTjmIcIMcqE8wMTFRd8K8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hT7P6Ohdsf2An3DF/F3mZiSV3C+TCy8NXWrEaVoEsjbDrR3M88AYxBRYpgjpQnHob b/rT4uMhgUbX7qTPXUKw+0WsEg+XYzHNOS5GoVcjJbonW2jNQIy1ychdPIaAXC3trE D+4IzAypgQjQkdiMwVnZoZdxv0+f4ePUE13YsHic= Date: Fri, 18 Sep 2020 17:20:26 +0300 From: Laurent Pinchart To: Krzysztof Kozlowski Cc: Linus Walleij , Bartosz Golaszewski , Rob Herring , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Manivannan Sadhasivam , Andy Gross , Bjorn Andersson , Palmer Dabbelt , Paul Walmsley , Hoan Tran , Serge Semin , Richard Fitzgerald , Lee Jones , Maxime Coquelin , Alexandre Torgue , Andreas =?utf-8?Q?F=C3=A4rber?= , Maxime Ripard , Chen-Yu Tsai , Matthias Brugger , Geert Uytterhoeven , Liam Girdwood , Mark Brown , Chris Packham , Anson Huang , Sungbo Eo , Stefan Agner , Srinivas Kandagatla , Magnus Damm , Yash Shah , Paul Kocialkowski , - , Matti Vaittinen , Amelie Delaunay , Cristian Ciocaltea , Paul Cercueil , Andy Teng , Sean Wang , Sricharan R , Chris Brandt , Jaroslav Kysela , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 09/13] dt-bindings: pinctrl: include common schema in GPIO controllers Message-ID: <20200918142026.GF28436@pendragon.ideasonboard.com> References: <20200917165301.23100-1-krzk@kernel.org> <20200917165301.23100-10-krzk@kernel.org> <20200917201204.GG3969@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On Fri, Sep 18, 2020 at 10:19:25AM +0200, Krzysztof Kozlowski wrote: > On Thu, 17 Sep 2020 at 22:12, Laurent Pinchart wrote: > > On Thu, Sep 17, 2020 at 06:52:57PM +0200, Krzysztof Kozlowski wrote: > > > Include the common GPIO schema in GPIO controllers to be sure all common > > > properties are properly validated. > > > > Shouldn't we delete the properties that are now redundant from these > > schemas ? > > Good point. However not with "additionalPropeties: false". Schema > requires all properties to be mentioned. I would need to use > "unevaluatedProperties: false" in each file. > > What is preferred? I've seen Rob advocating for unevaluatedProperties multiple times, but I'll let him comment on this, I don't want to speak for him. -- Regards, Laurent Pinchart