LKML Archive on lore.kernel.org
 help / color / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: uclinux-h8-devel@lists.sourceforge.jp,
	LKML <linux-kernel@vger.kernel.org>,
	Vlastimil Babka <vbabka@suse.cz>,
	Richard Weinberger <richard@sigma-star.at>,
	Arnd Bergmann <arnd@arndb.de>
Subject: [PATCH] h8300: Make irq disable and enable a compiler barrier
Date: Fri, 18 Sep 2020 15:25:07 -0400
Message-ID: <20200918152507.711865ce@gandalf.local.home> (raw)

From: Steven Rostedt (VMware) <rostedt@goodmis.org>

In a conversation on #linux-rt, it was asked if the irq disabling and
enabling functions were a compiler barrier, and reads wont happen outside
these functions from where they were in the call.

I stated that they most definitely need to be, otherwise we would have bugs
all over the place if not. And just to confirm, I looked at the
implementation on x86 which had "memory" as a constraint to the asm, and
that is a compiler barrier. As that was just one arch, I looked at others,
and all the other archs do the same but one. H8300 seems to fail here. And
that is most definitely a bug.

Add the compiler barrier to the enabling and disabling of interrupts on
H8300. As this is a really critical bug, I'm starting to wonder how much
this arch is really used. Let's see how quickly this patch gets added to
the arch, and if it is not applied or responded to within a month, I think
we can safely state that this arch is not maintained.

Reported-by: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
diff --git a/arch/h8300/include/asm/irqflags.h b/arch/h8300/include/asm/irqflags.h
index 48756b7f405e..477cb9d7785f 100644
--- a/arch/h8300/include/asm/irqflags.h
+++ b/arch/h8300/include/asm/irqflags.h
@@ -15,12 +15,12 @@ static inline h8300flags arch_local_save_flags(void)
 
 static inline void arch_local_irq_disable(void)
 {
-	__asm__ volatile ("orc  #0xc0,ccr");
+	__asm__ volatile ("orc  #0xc0,ccr" : : : "memory");
 }
 
 static inline void arch_local_irq_enable(void)
 {
-	__asm__ volatile ("andc #0x3f,ccr");
+	__asm__ volatile ("andc #0x3f,ccr" : : : "memory");
 }
 
 static inline h8300flags arch_local_irq_save(void)
@@ -28,13 +28,13 @@ static inline h8300flags arch_local_irq_save(void)
 	h8300flags flags;
 
 	__asm__ volatile ("stc ccr,%w0\n\t"
-		      "orc  #0xc0,ccr" : "=r" (flags));
+		      "orc  #0xc0,ccr" : "=r" (flags) : : "memory");
 	return flags;
 }
 
 static inline void arch_local_irq_restore(h8300flags flags)
 {
-	__asm__ volatile ("ldc %w0,ccr" : : "r" (flags) : "cc");
+	__asm__ volatile ("ldc %w0,ccr" : : "r" (flags) : "memory", "cc");
 }
 
 static inline int arch_irqs_disabled_flags(unsigned long flags)
@@ -55,13 +55,13 @@ static inline h8300flags arch_local_save_flags(void)
 
 static inline void arch_local_irq_disable(void)
 {
-	__asm__ volatile ("orc #0x80,ccr\n\t");
+	__asm__ volatile ("orc #0x80,ccr\n\t" : : : "memory");
 }
 
 static inline void arch_local_irq_enable(void)
 {
 	__asm__ volatile ("andc #0x7f,ccr\n\t"
-		      "andc #0xf0,exr\n\t");
+		      "andc #0xf0,exr\n\t" : : : "memory");
 }
 
 static inline h8300flags arch_local_irq_save(void)
@@ -71,7 +71,7 @@ static inline h8300flags arch_local_irq_save(void)
 	__asm__ volatile ("stc ccr,%w0\n\t"
 		      "stc exr,%x0\n\t"
 		      "orc  #0x80,ccr\n\t"
-		      : "=r" (flags));
+		      : "=r" (flags) : : "memory");
 	return flags;
 }
 
@@ -79,7 +79,7 @@ static inline void arch_local_irq_restore(h8300flags flags)
 {
 	__asm__ volatile ("ldc %w0,ccr\n\t"
 		      "ldc %x0,exr"
-		      : : "r" (flags) : "cc");
+		      : : "r" (flags) : "memory", "cc");
 }
 
 static inline int arch_irqs_disabled_flags(h8300flags flags)

             reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-18 19:25 Steven Rostedt [this message]
2020-09-28 20:16 ` Steven Rostedt
2020-10-05 17:36 ` Steven Rostedt
2020-10-12 18:47 ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200918152507.711865ce@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=richard@sigma-star.at \
    --cc=uclinux-h8-devel@lists.sourceforge.jp \
    --cc=vbabka@suse.cz \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git
	git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git
	git clone --mirror https://lore.kernel.org/lkml/10 lkml/git/10.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git