From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Ilie Halip <ilie.halip@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Rong Chen <rong.a.chen@intel.com>, Marco Elver <elver@google.com>,
Philip Li <philip.li@intel.com>, Borislav Petkov <bp@alien8.de>,
kasan-dev <kasan-dev@googlegroups.com>,
"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel.org>,
clang-built-linux <clang-built-linux@googlegroups.com>,
Peter Zijlstra <peterz@infradead.org>,
Nathan Chancellor <natechancellor@gmail.com>
Subject: Re: [PATCH] objtool: ignore unreachable trap after call to noreturn functions
Date: Fri, 18 Sep 2020 10:51:43 -0500 [thread overview]
Message-ID: <20200918154840.h3xbspb5jq7zw755@treble> (raw)
In-Reply-To: <CAHFW8PTFsmc7ykbrbdOYM6s-y1fpiV=7ee49BXaHjOkCMhBzhQ@mail.gmail.com>
On Fri, Sep 18, 2020 at 08:35:40AM +0300, Ilie Halip wrote:
> > The patch looks good to me. Which versions of Clang do the trap after
> > noreturn call? It would be good to have that in the commit message.
>
> I omitted this because it happens with all versions of clang that are
> supported for building the kernel. clang-9 is the oldest version that
> could build the mainline x86_64 kernel right now, and it has the same
> behavior.
Ok. It should at least mention that this is a Clang-specific thing,
since GCC's version of UBSAN_TRAP doesn't do it.
> Should I send a v2 with this info?
Yes, please.
--
Josh
next prev parent reply other threads:[~2020-09-18 15:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 8:49 [PATCH] objtool: ignore unreachable trap after call to noreturn functions Ilie Halip
2020-09-17 18:15 ` Nick Desaulniers
2020-09-17 22:16 ` Josh Poimboeuf
2020-09-18 5:35 ` Ilie Halip
2020-09-18 15:51 ` Josh Poimboeuf [this message]
2020-09-19 6:41 ` [PATCH v2] " Ilie Halip
2020-09-19 11:02 ` Sedat Dilek
2020-09-21 15:19 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200918154840.h3xbspb5jq7zw755@treble \
--to=jpoimboe@redhat.com \
--cc=bp@alien8.de \
--cc=clang-built-linux@googlegroups.com \
--cc=elver@google.com \
--cc=ilie.halip@gmail.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=peterz@infradead.org \
--cc=philip.li@intel.com \
--cc=rong.a.chen@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).