From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17C39C43463 for ; Fri, 18 Sep 2020 17:18:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D030121741 for ; Fri, 18 Sep 2020 17:18:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SCteN+Wc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726314AbgIRRSR (ORCPT ); Fri, 18 Sep 2020 13:18:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726126AbgIRRSQ (ORCPT ); Fri, 18 Sep 2020 13:18:16 -0400 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78F89C0613CE for ; Fri, 18 Sep 2020 10:18:16 -0700 (PDT) Received: by mail-pl1-x642.google.com with SMTP id d19so3343022pld.0 for ; Fri, 18 Sep 2020 10:18:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=7CLUrRFKwNrwTUyxJoKuleB6MYxxEKnOKzNF221gmC0=; b=SCteN+WchU83TDktKoSQ3XWkRzDQcCljQpmVUWTABHX4PiW2kuTWnYt6v6ZFRQvdFW nRGBw/xH92RJPO7iPmXAEIK21lPxjD4hLSCT2gFK72jkUzlOwDZpb1lEzaZMCPmJogP+ NHk6t8k94dWOzQz3eyJxo9P7moQjAWsUXZIEV93Vd53lQlkVWmr0khF3KFvOW3DfuZcq 7MW44efOKxCIGgUAgDLxSqGFa/0/nIbi3UDVEdNcvLQeIBYEUZsytbCVdhLYrbH/sLr7 sRIqVFzN+HQNGNLUCEiiKSY5lQ/4brngCZ3jpXZd1x966KkyajC+ezuhN2dpWqqkXBg3 KVig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7CLUrRFKwNrwTUyxJoKuleB6MYxxEKnOKzNF221gmC0=; b=uXIZzyT/rQX3cZlPDRSHn7ylW86RgU5w7V7D9Wh2IbVBILvCBr6szkDqx6Vu9boNIL Q5qdcSvp6At/wQly3WdfC0pdBY0zDhVmM/0o7mNNVr1KK9ItQmtMxEpwCDuB1Mh+PbXe xSMMspsMP8fyYTX0szflOqYDlu//5V7xuV52Ar657r3Ka7gu6VbJRrYC8EOO12x1yQ2D ooZobPtXcwNOMFy308VAvqo3COLqeSL5GgqP2Dc7LG/OAX19V6PA9LoIQx6LgKg56yEQ ebOjaVnQVBrs+3mb9rbawVNoeTKTV28CS1ui1T3FwAHRgC3PUfRA4hMvx9KW4fn2KUxW ZS2w== X-Gm-Message-State: AOAM530UxKHqhiG193vzKRx8tB5Ec0XhYMaWm22RqETxiR9EBAHFmfZN 13/t2Ga8O5lZaNtvaj0/a2BdP6Be4/pn X-Google-Smtp-Source: ABdhPJzk9kdvRZxiiMzV1zqsWZeRBM7A2B/AF2DI/wS8ijsthwkryajYpn8Unuqb6jaaVi9yX4Y7/Q== X-Received: by 2002:a17:902:8e8c:b029:d1:e5f9:9f7 with SMTP id bg12-20020a1709028e8cb02900d1e5f909f7mr16243903plb.72.1600449495685; Fri, 18 Sep 2020 10:18:15 -0700 (PDT) Received: from Mani-XPS-13-9360 ([2409:4072:6291:66eb:7496:aa7a:b42d:458c]) by smtp.gmail.com with ESMTPSA id q11sm3656897pgj.92.2020.09.18.10.18.11 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 18 Sep 2020 10:18:14 -0700 (PDT) Date: Fri, 18 Sep 2020 22:48:09 +0530 From: Manivannan Sadhasivam To: bbhatt@codeaurora.org Cc: Jeffrey Hugo , linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/3] bus: mhi: core: Remove warnings for missing MODULE_LICENSE() Message-ID: <20200918171809.GA3410@Mani-XPS-13-9360> References: <1600381176-37604-1-git-send-email-bbhatt@codeaurora.org> <1600381176-37604-2-git-send-email-bbhatt@codeaurora.org> <6f7b6be3-f52d-b082-6065-c75e3d89d252@codeaurora.org> <0e34b5a2562b776ea410c80479107581@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0e34b5a2562b776ea410c80479107581@codeaurora.org> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 18, 2020 at 09:49:05AM -0700, bbhatt@codeaurora.org wrote: > On 2020-09-18 07:27, Jeffrey Hugo wrote: > > On 9/17/2020 4:19 PM, Bhaumik Bhatt wrote: > > > When building MHI as a module, missing MODULE_LICENSE() warnings > > > are seen. Avoid them by adding the license and description > > > information for the files where the warnings are seen. > > > > > > Signed-off-by: Bhaumik Bhatt > > > --- > > > drivers/bus/mhi/core/boot.c | 3 +++ > > > drivers/bus/mhi/core/main.c | 3 +++ > > > drivers/bus/mhi/core/pm.c | 3 +++ > > > 3 files changed, 9 insertions(+) > > > > > > diff --git a/drivers/bus/mhi/core/boot.c b/drivers/bus/mhi/core/boot.c > > > index 24422f5..78140cc 100644 > > > --- a/drivers/bus/mhi/core/boot.c > > > +++ b/drivers/bus/mhi/core/boot.c > > > @@ -523,3 +523,6 @@ void mhi_fw_load_handler(struct mhi_controller > > > *mhi_cntrl) > > > error_alloc_fw_table: > > > release_firmware(firmware); > > > } > > > + > > > +MODULE_LICENSE("GPL v2"); > > > +MODULE_DESCRIPTION("MHI Host Interface"); > > > diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c > > > index 2cff5dd..172026f 100644 > > > --- a/drivers/bus/mhi/core/main.c > > > +++ b/drivers/bus/mhi/core/main.c > > > @@ -1533,3 +1533,6 @@ int mhi_poll(struct mhi_device *mhi_dev, u32 > > > budget) > > > return ret; > > > } > > > EXPORT_SYMBOL_GPL(mhi_poll); > > > + > > > +MODULE_LICENSE("GPL v2"); > > > +MODULE_DESCRIPTION("MHI Host Interface"); > > > diff --git a/drivers/bus/mhi/core/pm.c b/drivers/bus/mhi/core/pm.c > > > index ce4d969..72c3dbc 100644 > > > --- a/drivers/bus/mhi/core/pm.c > > > +++ b/drivers/bus/mhi/core/pm.c > > > @@ -1150,3 +1150,6 @@ void mhi_device_put(struct mhi_device *mhi_dev) > > > read_unlock_bh(&mhi_cntrl->pm_lock); > > > } > > > EXPORT_SYMBOL_GPL(mhi_device_put); > > > + > > > +MODULE_LICENSE("GPL v2"); > > > +MODULE_DESCRIPTION("MHI Host Interface"); > > > > > > > I would expect you only need to add the MODULE_* once per module, in > > which case main.c is probably the only place that needs it. > > Hi Jeff, > > I thought so too. This is to fix below warnings seen when building MHI as a > MODULE: > > WARNING: modpost: missing MODULE_LICENSE() in drivers/bus/mhi/core/main.o > WARNING: modpost: missing MODULE_LICENSE() in drivers/bus/mhi/core/pm.o > WARNING: modpost: missing MODULE_LICENSE() in drivers/bus/mhi/core/boot.o > > We've only had those in init.c so far. > Can you please test below diff to see if it fixes the warning? diff --git a/drivers/bus/mhi/core/Makefile b/drivers/bus/mhi/core/Makefile index 66e2700c9032..bc1469778cf8 100644 --- a/drivers/bus/mhi/core/Makefile +++ b/drivers/bus/mhi/core/Makefile @@ -1,3 +1,3 @@ -obj-$(CONFIG_MHI_BUS) := mhi.o +obj-$(CONFIG_MHI_BUS) += mhi.o mhi-y := init.o main.o pm.o boot.o Thanks, Mani > Thanks, > Bhaumik > > 'The Qualcomm Innovation Center, Inc. is a member of the Code Aurora > Forum,\na Linux Foundation Collaborative Project'