> Indeed, because jz4780_i2c_of_matches isn't within a CONFIG_OF ifdef > as is sometimes done and is when you need of_match_ptr(). IMO, the > commit msg should have something like "The driver is only used with > CONFIG_OF enabled, so of_match_ptr() is not necessary. > jz4780_i2c_of_matches is always defined." I think the commit message says that good enough.