From: Will Deacon <will@kernel.org>
To: peterz@infradead.org
Cc: David Howells <dhowells@redhat.com>,
Kees Cook <keescook@chromium.org>,
Xiaoming Ni <nixiaoming@huawei.com>,
David Windsor <dwindsor@gmail.com>,
Hans Liljestrand <ishkamiel@gmail.com>,
Elena Reshetova <elena.reshetova@intel.com>,
Paul Moore <paul@paul-moore.com>,
edumazet@google.com, paulmck@kernel.org, shakeelb@google.com,
James Morris <jamorris@linux.microsoft.com>,
alex.huangjianhui@huawei.com, dylix.dailei@huawei.com,
chenzefeng2@huawei.com, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH] locking/refcount: Provide __refcount API to obtain the old value
Date: Mon, 21 Sep 2020 12:22:19 +0100 [thread overview]
Message-ID: <20200921112218.GB2139@willie-the-truck> (raw)
In-Reply-To: <20200729111120.GA2638@hirez.programming.kicks-ass.net>
On Wed, Jul 29, 2020 at 01:11:20PM +0200, peterz@infradead.org wrote:
> On Tue, Jul 28, 2020 at 11:56:38AM +0100, David Howells wrote:
> > Peter Zijlstra <peterz@infradead.org> wrote:
> >
> > > > Please do not _undo_ the changes; just add the API you need.
> > >
> > > add_return and sub_return are horrible interface for refcount, which is
> > > the problem.
> > >
> > > If you meant: refcount_dec(), but want the old value for tracing, you
> > > want a different ordering than if you wanted to do
> > > refcount_dec_and_test(); dec_return can't know this.
> > >
> > > David, would something like a __refcount_*() API work where there is a
> > > 3rd argument (int *), which, if !NULL, will be assigned the old value?
> >
> > That would be fine, though the number needs to be something I can interpret
> > easily when looking through the traces. It would also be okay if there was an
> > interpretation function that I could use in the trace point when setting the
> > variable.
>
> I'm not entirely sure what you mean with interpret, provided you don't
> trigger a refcount fail, the number will be just what you expect and
> would get from refcount_read(). If you do trigger a fail, you'll get a
> negative value.
>
> How's the below? I didn't provide __refcount versions for the external
> functions, I suppose that can be done too, but wondered if you really
> needed those.
It looks like this didn't go anywhere, but I'm supportive of the general
idea if it's useful to somebody. The only part I find a bit grotty is that
we end up introducing a bunch of redundancy in some of the new functions,
e.g.:
> @@ -219,9 +235,14 @@ static inline void refcount_add(int i, r
> *
> * Return: true if the increment was successful, false otherwise
> */
> +static inline __must_check bool __refcount_inc_not_zero(refcount_t *r, int *oldp)
> +{
> + return __refcount_add_not_zero(1, r, oldp);
> +}
Where returning both a bool to indicate whether the old value was zero
and also the old value itself is a bit OTT.
Will
next prev parent reply other threads:[~2020-09-21 11:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 18:34 [PATCH 0/3] Convert nsproxy, groups, and creds to refcount_t Kees Cook
2020-06-12 18:34 ` [PATCH 1/3] nsproxy: convert nsproxy.count " Kees Cook
2020-06-12 18:34 ` [PATCH 2/3] groups: convert group_info.usage " Kees Cook
2020-06-15 0:57 ` [groups] 67467ae141: will-it-scale.per_process_ops 4.3% improvement kernel test robot
2020-06-12 18:34 ` [PATCH 3/3] creds: convert cred.usage to refcount_t Kees Cook
2020-06-15 2:02 ` Xiaoming Ni
2020-06-15 2:10 ` [PATCH 0/3] Convert nsproxy, groups, and creds " Xiaoming Ni
2020-06-15 3:55 ` Kees Cook
2020-06-15 5:35 ` Reshetova, Elena
2020-06-15 18:08 ` Kees Cook
2020-06-18 7:39 ` Reshetova, Elena
2020-07-21 11:02 ` David Howells
2020-07-21 10:51 ` David Howells
2020-07-21 18:44 ` Kees Cook
2020-07-21 19:51 ` Peter Zijlstra
2020-07-28 10:56 ` David Howells
2020-07-29 11:11 ` [RFC][PATCH] locking/refcount: Provide __refcount API to obtain the old value peterz
2020-07-29 11:37 ` peterz
2020-07-29 19:29 ` Kees Cook
2020-07-29 19:30 ` Kees Cook
2020-08-27 7:54 ` [tip: locking/core] " tip-bot2 for Peter Zijlstra
2020-09-21 11:22 ` Will Deacon [this message]
2021-01-26 11:25 ` [RFC][PATCH] " David Howells
2020-07-29 20:41 ` David Howells
2020-07-29 20:52 ` Kees Cook
2020-07-28 11:01 ` [PATCH 0/3] Convert nsproxy, groups, and creds to refcount_t David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200921112218.GB2139@willie-the-truck \
--to=will@kernel.org \
--cc=alex.huangjianhui@huawei.com \
--cc=chenzefeng2@huawei.com \
--cc=dhowells@redhat.com \
--cc=dwindsor@gmail.com \
--cc=dylix.dailei@huawei.com \
--cc=edumazet@google.com \
--cc=elena.reshetova@intel.com \
--cc=ishkamiel@gmail.com \
--cc=jamorris@linux.microsoft.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nixiaoming@huawei.com \
--cc=paul@paul-moore.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).