* [PATCH -next] mlxsw: spectrum_router: simplify the return expression of __mlxsw_sp_router_init()
@ 2020-09-21 13:10 Qinglang Miao
2020-09-21 13:41 ` Ido Schimmel
2020-09-21 20:46 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Qinglang Miao @ 2020-09-21 13:10 UTC (permalink / raw)
To: Jiri Pirko, Ido Schimmel
Cc: David S. Miller, Jakub Kicinski, netdev, linux-kernel, Qinglang Miao
Simplify the return expression.
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
---
drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
index 24f1fd1f8..9188fc32b 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c
@@ -8033,7 +8033,6 @@ static int __mlxsw_sp_router_init(struct mlxsw_sp *mlxsw_sp)
bool usp = net->ipv4.sysctl_ip_fwd_update_priority;
char rgcr_pl[MLXSW_REG_RGCR_LEN];
u64 max_rifs;
- int err;
if (!MLXSW_CORE_RES_VALID(mlxsw_sp->core, MAX_RIFS))
return -EIO;
@@ -8042,10 +8041,7 @@ static int __mlxsw_sp_router_init(struct mlxsw_sp *mlxsw_sp)
mlxsw_reg_rgcr_pack(rgcr_pl, true, true);
mlxsw_reg_rgcr_max_router_interfaces_set(rgcr_pl, max_rifs);
mlxsw_reg_rgcr_usp_set(rgcr_pl, usp);
- err = mlxsw_reg_write(mlxsw_sp->core, MLXSW_REG(rgcr), rgcr_pl);
- if (err)
- return err;
- return 0;
+ return mlxsw_reg_write(mlxsw_sp->core, MLXSW_REG(rgcr), rgcr_pl);
}
static void __mlxsw_sp_router_fini(struct mlxsw_sp *mlxsw_sp)
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] mlxsw: spectrum_router: simplify the return expression of __mlxsw_sp_router_init()
2020-09-21 13:10 [PATCH -next] mlxsw: spectrum_router: simplify the return expression of __mlxsw_sp_router_init() Qinglang Miao
@ 2020-09-21 13:41 ` Ido Schimmel
2020-09-21 20:46 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Ido Schimmel @ 2020-09-21 13:41 UTC (permalink / raw)
To: Qinglang Miao
Cc: Jiri Pirko, David S. Miller, Jakub Kicinski, netdev, linux-kernel
On Mon, Sep 21, 2020 at 09:10:41PM +0800, Qinglang Miao wrote:
> Simplify the return expression.
>
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] mlxsw: spectrum_router: simplify the return expression of __mlxsw_sp_router_init()
2020-09-21 13:10 [PATCH -next] mlxsw: spectrum_router: simplify the return expression of __mlxsw_sp_router_init() Qinglang Miao
2020-09-21 13:41 ` Ido Schimmel
@ 2020-09-21 20:46 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-09-21 20:46 UTC (permalink / raw)
To: miaoqinglang; +Cc: jiri, idosch, kuba, netdev, linux-kernel
From: Qinglang Miao <miaoqinglang@huawei.com>
Date: Mon, 21 Sep 2020 21:10:41 +0800
> Simplify the return expression.
>
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-21 20:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-21 13:10 [PATCH -next] mlxsw: spectrum_router: simplify the return expression of __mlxsw_sp_router_init() Qinglang Miao
2020-09-21 13:41 ` Ido Schimmel
2020-09-21 20:46 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).