From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1B5CC43464 for ; Mon, 21 Sep 2020 13:11:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 755BE2076E for ; Mon, 21 Sep 2020 13:11:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727460AbgIUNKz (ORCPT ); Mon, 21 Sep 2020 09:10:55 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:43170 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727426AbgIUNKp (ORCPT ); Mon, 21 Sep 2020 09:10:45 -0400 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id EA8FCE349BEBA8CD73F2; Mon, 21 Sep 2020 21:10:42 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.487.0; Mon, 21 Sep 2020 21:10:35 +0800 From: Qinglang Miao To: Joshua Morris , Philip Kelleher , Jens Axboe CC: , , "Qinglang Miao" Subject: [PATCH -next] rsxx: simplify the return expression of rsxx_save_config() Date: Mon, 21 Sep 2020 21:10:59 +0800 Message-ID: <20200921131059.92987-1-miaoqinglang@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Simplify the return expression. Signed-off-by: Qinglang Miao --- drivers/block/rsxx/config.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/block/rsxx/config.c b/drivers/block/rsxx/config.c index 11ed1d964..c6de88186 100644 --- a/drivers/block/rsxx/config.c +++ b/drivers/block/rsxx/config.c @@ -84,7 +84,6 @@ static void config_data_cpu_to_le(struct rsxx_card_cfg *cfg) static int rsxx_save_config(struct rsxx_cardinfo *card) { struct rsxx_card_cfg cfg; - int st; memcpy(&cfg, &card->config, sizeof(cfg)); @@ -107,11 +106,7 @@ static int rsxx_save_config(struct rsxx_cardinfo *card) config_data_swab(&cfg); config_hdr_cpu_to_be(&cfg.hdr); - st = rsxx_creg_write(card, CREG_ADD_CONFIG, sizeof(cfg), &cfg, 1); - if (st) - return st; - - return 0; + return rsxx_creg_write(card, CREG_ADD_CONFIG, sizeof(cfg), &cfg, 1); } int rsxx_load_config(struct rsxx_cardinfo *card) -- 2.23.0