From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3D92C43465 for ; Mon, 21 Sep 2020 15:28:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 741C12085B for ; Mon, 21 Sep 2020 15:28:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=android.com header.i=@android.com header.b="iHfyA/N+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727617AbgIUP2x (ORCPT ); Mon, 21 Sep 2020 11:28:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726501AbgIUP2r (ORCPT ); Mon, 21 Sep 2020 11:28:47 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6BE52C061755 for ; Mon, 21 Sep 2020 08:28:47 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id l9so13190066wme.3 for ; Mon, 21 Sep 2020 08:28:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=android.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=v0nAWnY87KOUm3TmW0inHlpng/Oa6fR5bWkP5SWjBms=; b=iHfyA/N+cFOP3dm1xHQGJi0wTCEYS8CK4/qFGF17fbWz0r7GMLlK/jCS+6uIZx+gzi K87BVBTLovwDs2dO7vo8xivjahY5AFY/10N0i93JiU+FwjfUxi2K/q1KLzO6nLDxKOQz XsWR/rQJl9DsSb8J4EyJKaKSDMvS0VVObRsDk9a+0yilVx4+EnfaAUiax9D6xTzEwgaM 0wo6XQs7uMA1mh4CQAvsGIDDZ1ae4xjYUrgE0QYKN40dxsS51WSxuqDEVP+JkjZgmHoN zv+5BjwAZOLTVSIoB6NnBrXQzCA6nnCIEw6Z8atTdxLSW/UwUWMs+tvRIMRHoDjqoWXY e0CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=v0nAWnY87KOUm3TmW0inHlpng/Oa6fR5bWkP5SWjBms=; b=At1VgmjeEB4kgXdyKcr4YF9RdcQmBBYvOKEl4HCiEhjXFlLFHLYzsYH+5Tc8qZu1Ce eDCnz2N7Ib43KaFf228c/bvEEpOVbg7BLzkzenKQaXj+OXvP8X43fGH6U8ct8Cg9Wf8e xuvtOXD6cINxYQsL1y3gEUrsf0vcyt8XxHgtoXvxnyjhsFDZfWxIPtG0ioFSDxZefud0 xvcg63w/AjhrlkrjmYARO8ytlKnqDZJJyn1ArTY3Ex4PcF6882L6F9rKpBYQZVuulyl9 /28rbBiNchWxl1+X3Vft1ZR/2tzywNxrIFKq0wLMyf3yB1DcOzp+gVcxCOFLt9y32fYf FS6A== X-Gm-Message-State: AOAM5313DrMeczkB6qkPwYXiKvZVvZWJCvPWEimYYWxe60wanBYE6UTX hrdrbGsltVgl+owU7Z7KBdVj0w== X-Google-Smtp-Source: ABdhPJwQOEN7N4ON4+kBSC+xSudCe51Kv4hpYOWF5ZhQL4sia2gLckZUNo0SrhV93J5PkQgaKEzxuA== X-Received: by 2002:a7b:ce86:: with SMTP id q6mr155409wmj.163.1600702126177; Mon, 21 Sep 2020 08:28:46 -0700 (PDT) Received: from google.com ([2a00:79e0:d:210:7220:84ff:fe09:7d5c]) by smtp.gmail.com with ESMTPSA id k5sm20168920wmb.19.2020.09.21.08.28.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Sep 2020 08:28:45 -0700 (PDT) Date: Mon, 21 Sep 2020 16:28:44 +0100 From: Alessio Balsini To: Jens Axboe Cc: Alessio Balsini , Miklos Szeredi , Akilesh Kailash , Amir Goldstein , David Anderson , Eric Yan , Jann Horn , Martijn Coenen , Palmer Dabbelt , Paul Lawrence , Stefano Duo , Zimuzo Ezeozue , fuse-devel@lists.sourceforge.net, kernel-team@android.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V8 3/3] fuse: Handle AIO read and write in passthrough Message-ID: <20200921152844.GA600068@google.com> References: <20200911163403.79505-1-balsini@android.com> <20200911163403.79505-4-balsini@android.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 11, 2020 at 11:23:22AM -0600, Jens Axboe wrote: > On 9/11/20 10:34 AM, Alessio Balsini wrote: > > Extend the passthrough feature by handling asynchronous IO both for read > > and write operations. > > When an AIO request is received, targeting a FUSE file with passthrough > > functionality enabled, a new identical AIO request is created, the file > > pointer of which is updated with the file pointer of the lower file system, > > and the completion handler is set with a special AIO passthrough handler. > > The lower file system AIO request is allocated in dynamic kernel memory > > and, when it completes, the allocated memory is freed and the completion > > signal is propagated to the FUSE AIO request by triggering its completion > > callback as well. > > > > Signed-off-by: Alessio Balsini > > --- > > fs/fuse/passthrough.c | 66 +++++++++++++++++++++++++++++++++++++++++-- > > 1 file changed, 63 insertions(+), 3 deletions(-) > > > > diff --git a/fs/fuse/passthrough.c b/fs/fuse/passthrough.c > > index 44a78e02f45d..87b57b26fd8a 100644 > > --- a/fs/fuse/passthrough.c > > +++ b/fs/fuse/passthrough.c > > @@ -2,10 +2,16 @@ > > > > #include "fuse_i.h" > > > > +#include > > What is this include for? It's not using any aio parts at all. > > -- > Jens Axboe > Slipped from a cleanup. Fixed. Thanks! Alessio