From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 561F6C43465 for ; Mon, 21 Sep 2020 17:06:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 184342084C for ; Mon, 21 Sep 2020 17:06:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600707979; bh=7nBeLG4x7GlEf44WYDfSngB9wg7YMgJ3n2peDL60sGs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=wjhigAIqf4sXKi46Xhy2Zyw9HUbrNyTcmm/ksPDBpeCEfZ0uQ2chtFeLqWry9FO02 uMD8R94xh815jx9C0PUvGcnTEeaJJWedYcllrV8Ko/yGqLEfwv5JO94hOWhmuLsUzO aaz9gy6LjcOumfgfWw7X+F/wdUadp+NPRiq+fpt8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728815AbgIURGQ (ORCPT ); Mon, 21 Sep 2020 13:06:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:58586 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728453AbgIUQct (ORCPT ); Mon, 21 Sep 2020 12:32:49 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 006732396F; Mon, 21 Sep 2020 16:32:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600705968; bh=7nBeLG4x7GlEf44WYDfSngB9wg7YMgJ3n2peDL60sGs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YyBJlDcpZ7jXK8FSnZmRTtONG2MzF6961+Y+ztoKs9hvI2tyxekzJuFg7EAx6GMus kQq/LbgtAlsHqMG+zC73Gw+6m1tpGtTARlHyGOZ/0noDfYZ9nW501chXT1jTlpcpUO iYC0+qQ6SmqC8TtqJdK90600sf35cP2DLARou2S4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Laurent Pinchart , Randy Dunlap , Sasha Levin Subject: [PATCH 4.4 33/46] rapidio: Replace select DMAENGINES with depends on Date: Mon, 21 Sep 2020 18:27:49 +0200 Message-Id: <20200921162034.812516818@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200921162033.346434578@linuxfoundation.org> References: <20200921162033.346434578@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Laurent Pinchart [ Upstream commit d2b86100245080cfdf1e95e9e07477474c1be2bd ] Enabling a whole subsystem from a single driver 'select' is frowned upon and won't be accepted in new drivers, that need to use 'depends on' instead. Existing selection of DMAENGINES will then cause circular dependencies. Replace them with a dependency. Signed-off-by: Laurent Pinchart Acked-by: Randy Dunlap Signed-off-by: Sasha Levin --- drivers/rapidio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rapidio/Kconfig b/drivers/rapidio/Kconfig index 3e3be57e9a1a1..4d0c1a40a6e65 100644 --- a/drivers/rapidio/Kconfig +++ b/drivers/rapidio/Kconfig @@ -25,7 +25,7 @@ config RAPIDIO_ENABLE_RX_TX_PORTS config RAPIDIO_DMA_ENGINE bool "DMA Engine support for RapidIO" depends on RAPIDIO - select DMADEVICES + depends on DMADEVICES select DMA_ENGINE help Say Y here if you want to use DMA Engine frameork for RapidIO data -- 2.25.1