From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9BF4C4363C for ; Mon, 21 Sep 2020 20:46:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 65C03218AC for ; Mon, 21 Sep 2020 20:46:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600721163; bh=EdurATGxug8cG+oyNYLURJIjRYdM3Db8byGV5R+MXAw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=hgHIpbQzBcEjhl84zN/+mPHacxO2UuERdwdPKO4syPw5hPzbVTGoAnh0x0DElINCt MHngWkrtUKpL8916Wu8Iz7KmJ2f/FmFOz8FUWfPbWRMp9UY1z4SI9AZFrkKYfbl1C0 gwBnBpBM8pcj91wZxjrKaG3Gd0lg0MgOkowUi/ts= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727793AbgIUUqC (ORCPT ); Mon, 21 Sep 2020 16:46:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:53890 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726471AbgIUUqC (ORCPT ); Mon, 21 Sep 2020 16:46:02 -0400 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D37C221BE5; Mon, 21 Sep 2020 20:45:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600721161; bh=EdurATGxug8cG+oyNYLURJIjRYdM3Db8byGV5R+MXAw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2EmwJzFSBBPOPx6F855kk70qAf3unPskCBeHSbPpZVJNbW7TPKyCEWvjHhP623NnE 71cFz77tBtPoIb0OSrqSyQWabxmFq6g91n7EtrDlo4xAG9MTKOhh6CztBU8+s1/vxU hbkVuOo6YgAefgKUlk5L+eWpvbnn/0eJnlyrBUS4= Date: Mon, 21 Sep 2020 21:45:57 +0100 From: Will Deacon To: kernel test robot Cc: Yu Kuai , robdclark@gmail.com, joro@8bytes.org, kbuild-all@lists.01.org, clang-built-linux@googlegroups.com, iommu@lists.linux-foundation.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, yi.zhang@huawei.com Subject: Re: [PATCH] iommu/qcom: add missing put_device() call in qcom_iommu_of_xlate() Message-ID: <20200921204556.GB3811@willie-the-truck> References: <20200918011357.909335-1-yukuai3@huawei.com> <202009220340.bJfsaeQn%lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202009220340.bJfsaeQn%lkp@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 22, 2020 at 03:13:53AM +0800, kernel test robot wrote: > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on iommu/next] > [also build test WARNING on linus/master v5.9-rc6 next-20200921] > [cannot apply to robclark/msm-next] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/0day-ci/linux/commits/Yu-Kuai/iommu-qcom-add-missing-put_device-call-in-qcom_iommu_of_xlate/20200918-091341 > base: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next > config: arm64-randconfig-r023-20200920 (attached as .config) > compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 4e8c028158b56d9c2142a62464e8e0686bde3584) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # install arm64 cross compiling tool for clang build > # apt-get install binutils-aarch64-linux-gnu > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All warnings (new ones prefixed by >>): > > >> drivers/iommu/arm/arm-smmu/qcom_iommu.c:601:4: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation] > return -EINVAL; > ^ > drivers/iommu/arm/arm-smmu/qcom_iommu.c:599:3: note: previous statement is here > if (WARN_ON(qcom_iommu != dev_iommu_priv_get(dev))) Oh, this looks like a nasty bug. Seems we're missing some braces. Will