From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB88BC4727C for ; Mon, 21 Sep 2020 22:19:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6855F23A63 for ; Mon, 21 Sep 2020 22:19:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600726796; bh=nsVCQXGW+vEBQKem+qf4fpSs9HOCy3YOzLNGU43qo3k=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=FLtBCTzaSLK8u7CiC1jXCVRe52g97EmRm/ONqe/i5MFWlPquhVOy1DSHCPrhtguBo ZmZ2OYKPTENI8u2oOOA7bl7JYBQJQ3yCm9lDmTNt7pv1dfOUKldEHsxqqCM87cH8Sz Cz1maEM8LTOhkC+DbTp8gkc1EWNa687Jipw6Qhos= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728549AbgIUWTz (ORCPT ); Mon, 21 Sep 2020 18:19:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:40756 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726457AbgIUWTy (ORCPT ); Mon, 21 Sep 2020 18:19:54 -0400 Received: from localhost (52.sub-72-107-123.myvzw.com [72.107.123.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5604F23A60; Mon, 21 Sep 2020 22:19:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600726794; bh=nsVCQXGW+vEBQKem+qf4fpSs9HOCy3YOzLNGU43qo3k=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=uLC5peuzDtxsOjb6SxAIq4tn6MBy9Awalcr5TWZvRKB0iErsGDoAB/arYYd0TXr2c UBSyXWbCqYMy9w0AWL+tjmbuPvNy1Rqx/RSGXpYQXE1v3CSP+XwfNuv70C1xpMrSzj UDqAlig4j1FiV8fyguB3wxleiw0Qx04nxP9xMvCQ= Date: Mon, 21 Sep 2020 17:19:53 -0500 From: Bjorn Helgaas To: peterz@infradead.org Cc: kan.liang@linux.intel.com, mingo@redhat.com, linux-kernel@vger.kernel.org, bhelgaas@google.com, eranian@google.com, ak@linux.intel.com Subject: Re: [RESEND PATCH V2 0/6] Support PCIe3 uncore PMU on Snow Ridge Message-ID: <20200921221953.GA2139522@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200921150631.GS1362448@hirez.programming.kicks-ass.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 21, 2020 at 05:06:31PM +0200, peterz@infradead.org wrote: > On Mon, Sep 14, 2020 at 07:34:14AM -0700, kan.liang@linux.intel.com wrote: > > From: Kan Liang > > > > Changes since V1: > > - Drop the platform device solution > > - A new uncore PCI sub driver solution is introduced which searches > > the PCIe Root Port device via pci_get_device() and id table. > > Register a PCI bus notifier for the remove notification. Once the > > device is removed, the uncore driver can be notified to unregister > > the corresponding PMU. > > - Modify the parameters of uncore_pci_pmu_unregister() function. > > Bjorn, you hated on the last version of this thing, are you OK with this > one? Yep, this is OK with me.