linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] ipvs: Remove unused macros
@ 2020-09-18 13:16 YueHaibing
  2020-09-21  7:24 ` Simon Horman
  0 siblings, 1 reply; 3+ messages in thread
From: YueHaibing @ 2020-09-18 13:16 UTC (permalink / raw)
  To: wensong, horms, ja, pablo, kadlec, fw, davem, kuba
  Cc: netdev, lvs-devel, netfilter-devel, coreteam, linux-kernel, YueHaibing

They are not used since commit e4ff67513096 ("ipvs: add
sync_maxlen parameter for the sync daemon")

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 net/netfilter/ipvs/ip_vs_sync.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/net/netfilter/ipvs/ip_vs_sync.c b/net/netfilter/ipvs/ip_vs_sync.c
index 2b8abbfe018c..16b48064f715 100644
--- a/net/netfilter/ipvs/ip_vs_sync.c
+++ b/net/netfilter/ipvs/ip_vs_sync.c
@@ -242,9 +242,6 @@ struct ip_vs_sync_thread_data {
       |                    IPVS Sync Connection (1)                   |
 */
 
-#define SYNC_MESG_HEADER_LEN	4
-#define MAX_CONNS_PER_SYNCBUFF	255 /* nr_conns in ip_vs_sync_mesg is 8 bit */
-
 /* Version 0 header */
 struct ip_vs_sync_mesg_v0 {
 	__u8                    nr_conns;
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] ipvs: Remove unused macros
  2020-09-18 13:16 [PATCH net-next] ipvs: Remove unused macros YueHaibing
@ 2020-09-21  7:24 ` Simon Horman
  2020-09-21 23:35   ` Pablo Neira Ayuso
  0 siblings, 1 reply; 3+ messages in thread
From: Simon Horman @ 2020-09-21  7:24 UTC (permalink / raw)
  To: YueHaibing
  Cc: wensong, ja, pablo, kadlec, fw, davem, kuba, netdev, lvs-devel,
	netfilter-devel, coreteam, linux-kernel

On Fri, Sep 18, 2020 at 09:16:56PM +0800, YueHaibing wrote:
> They are not used since commit e4ff67513096 ("ipvs: add
> sync_maxlen parameter for the sync daemon")
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Thanks, this look good to me.

Acked-by: Simon Horman <horms@verge.net.au>

Pablo, please consider this for nf-next.

> ---
>  net/netfilter/ipvs/ip_vs_sync.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/net/netfilter/ipvs/ip_vs_sync.c b/net/netfilter/ipvs/ip_vs_sync.c
> index 2b8abbfe018c..16b48064f715 100644
> --- a/net/netfilter/ipvs/ip_vs_sync.c
> +++ b/net/netfilter/ipvs/ip_vs_sync.c
> @@ -242,9 +242,6 @@ struct ip_vs_sync_thread_data {
>        |                    IPVS Sync Connection (1)                   |
>  */
>  
> -#define SYNC_MESG_HEADER_LEN	4
> -#define MAX_CONNS_PER_SYNCBUFF	255 /* nr_conns in ip_vs_sync_mesg is 8 bit */
> -
>  /* Version 0 header */
>  struct ip_vs_sync_mesg_v0 {
>  	__u8                    nr_conns;
> -- 
> 2.17.1
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] ipvs: Remove unused macros
  2020-09-21  7:24 ` Simon Horman
@ 2020-09-21 23:35   ` Pablo Neira Ayuso
  0 siblings, 0 replies; 3+ messages in thread
From: Pablo Neira Ayuso @ 2020-09-21 23:35 UTC (permalink / raw)
  To: Simon Horman
  Cc: YueHaibing, wensong, ja, kadlec, fw, davem, kuba, netdev,
	lvs-devel, netfilter-devel, coreteam, linux-kernel

On Mon, Sep 21, 2020 at 09:24:40AM +0200, Simon Horman wrote:
> On Fri, Sep 18, 2020 at 09:16:56PM +0800, YueHaibing wrote:
> > They are not used since commit e4ff67513096 ("ipvs: add
> > sync_maxlen parameter for the sync daemon")
> > 
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> 
> Thanks, this look good to me.
> 
> Acked-by: Simon Horman <horms@verge.net.au>
> 
> Pablo, please consider this for nf-next.

Applied, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-09-21 23:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-18 13:16 [PATCH net-next] ipvs: Remove unused macros YueHaibing
2020-09-21  7:24 ` Simon Horman
2020-09-21 23:35   ` Pablo Neira Ayuso

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).