From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Xiaoliang Yang <xiaoliang.yang_1@nxp.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"allan.nielsen@microchip.com" <allan.nielsen@microchip.com>,
"joergen.andreasen@microchip.com"
<joergen.andreasen@microchip.com>,
"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
Alexandru Marginean <alexandru.marginean@nxp.com>,
Po Liu <po.liu@nxp.com>, Claudiu Manoil <claudiu.manoil@nxp.com>,
Leo Li <leoyang.li@nxp.com>
Subject: Re: [net-next] net: dsa: felix: convert TAS link speed based on phylink speed
Date: Tue, 22 Sep 2020 11:36:45 +0000 [thread overview]
Message-ID: <20200922113644.h5vyxmdtg2dickpg@skbuf> (raw)
In-Reply-To: <20200922104302.17662-1-xiaoliang.yang_1@nxp.com>
Hi Xiaoliang,
On Tue, Sep 22, 2020 at 06:43:02PM +0800, Xiaoliang Yang wrote:
> state->speed holds a value of 10, 100, 1000 or 2500, but
> QSYS_TAG_CONFIG_LINK_SPEED expects a value of 0, 1, 2, 3. So convert the
> speed to a proper value.
>
> Fixes: de143c0e274b ("net: dsa: felix: Configure Time-Aware Scheduler via
> taprio offload")
>
> Signed-off-by: Xiaoliang Yang <xiaoliang.yang_1@nxp.com>
> ---
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
But next time keep in mind the following:
- The Fixes: tag should never wrap on multiple lines, even if it exceeds
80 characters.
- Patches that fix a problem in net-next only should go to David's
net-next tree. Patches that fix a problem on Linus Torvalds' tree
should go to David's "net" tree. This one should go to "net", not to
"net-next".
- All tags (Fixes, Signed-off-by, etc) should be grouped together with
no empty lines between them.
Actually due to the first issue I mentioned, could you please resend
this?
Thanks,
-Vladimir
next prev parent reply other threads:[~2020-09-22 11:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 10:43 [net-next] net: dsa: felix: convert TAS link speed based on phylink speed Xiaoliang Yang
2020-09-22 11:36 ` Vladimir Oltean [this message]
2020-09-24 2:10 ` Xiaoliang Yang
2020-09-24 12:30 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200922113644.h5vyxmdtg2dickpg@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandru.marginean@nxp.com \
--cc=allan.nielsen@microchip.com \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=joergen.andreasen@microchip.com \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=po.liu@nxp.com \
--cc=xiaoliang.yang_1@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).