linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] leds: lm3552: Fix warnings for undefined parameters
@ 2020-09-22 19:06 Dan Murphy
  2020-09-22 19:06 ` [PATCH 2/2] leds: lm36274: Fix warning " Dan Murphy
  2020-09-23 13:14 ` [PATCH 1/2] leds: lm3552: Fix warnings " Marek Behun
  0 siblings, 2 replies; 6+ messages in thread
From: Dan Murphy @ 2020-09-22 19:06 UTC (permalink / raw)
  To: pavel; +Cc: linux-leds, linux-kernel, marek.behun, Dan Murphy

Fix warnings for undefined parameters when W=1 is used.

Fixes: bc1b8492c764f ("leds: lm3532: Introduce the lm3532 LED driver")
Signed-off-by: Dan Murphy <dmurphy@ti.com>
---
 drivers/leds/leds-lm3532.c | 50 +++++++++++++++++++-------------------
 1 file changed, 25 insertions(+), 25 deletions(-)

diff --git a/drivers/leds/leds-lm3532.c b/drivers/leds/leds-lm3532.c
index 9b6973217cc0..95221d1e3861 100644
--- a/drivers/leds/leds-lm3532.c
+++ b/drivers/leds/leds-lm3532.c
@@ -96,15 +96,15 @@
 
 /*
  * struct lm3532_als_data
- * @config - value of ALS configuration register
- * @als1_imp_sel - value of ALS1 resistor select register
- * @als2_imp_sel - value of ALS2 resistor select register
- * @als_avrg_time - ALS averaging time
- * @als_input_mode - ALS input mode for brightness control
- * @als_vmin - Minimum ALS voltage
- * @als_vmax - Maximum ALS voltage
- * @zone_lo - values of ALS lo ZB(Zone Boundary) registers
- * @zone_hi - values of ALS hi ZB(Zone Boundary) registers
+ * @config: value of ALS configuration register
+ * @als1_imp_sel: value of ALS1 resistor select register
+ * @als2_imp_sel: value of ALS2 resistor select register
+ * @als_avrg_time: ALS averaging time
+ * @als_input_mode: ALS input mode for brightness control
+ * @als_vmin: Minimum ALS voltage
+ * @als_vmax: Maximum ALS voltage
+ * @zone_lo: values of ALS lo ZB(Zone Boundary) registers
+ * @zone_hi: values of ALS hi ZB(Zone Boundary) registers
  */
 struct lm3532_als_data {
 	u8 config;
@@ -121,14 +121,14 @@ struct lm3532_als_data {
 /**
  * struct lm3532_led
  * @led_dev: led class device
- * @priv - Pointer the device data structure
- * @control_bank - Control bank the LED is associated to
- * @mode - Mode of the LED string
- * @ctrl_brt_pointer - Zone target register that controls the sink
- * @num_leds - Number of LED strings are supported in this array
- * @full_scale_current - The full-scale current setting for the current sink.
- * @led_strings - The LED strings supported in this array
- * @enabled - Enabled status
+ * @priv: Pointer the device data structure
+ * @control_bank: Control bank the LED is associated to
+ * @mode: Mode of the LED string
+ * @ctrl_brt_pointer: Zone target register that controls the sink
+ * @num_leds: Number of LED strings are supported in this array
+ * @full_scale_current: The full-scale current setting for the current sink.
+ * @led_strings: The LED strings supported in this array
+ * @enabled: Enabled status
  */
 struct lm3532_led {
 	struct led_classdev led_dev;
@@ -145,16 +145,16 @@ struct lm3532_led {
 
 /**
  * struct lm3532_data
- * @enable_gpio - Hardware enable gpio
+ * @enable_gpio: Hardware enable gpio
  * @regulator: regulator
  * @client: i2c client
- * @regmap - Devices register map
- * @dev - Pointer to the devices device struct
- * @lock - Lock for reading/writing the device
- * @als_data - Pointer to the als data struct
- * @runtime_ramp_up - Runtime ramp up setting
- * @runtime_ramp_down - Runtime ramp down setting
- * @leds - Array of LED strings
+ * @regmap: Devices register map
+ * @dev: Pointer to the devices device struct
+ * @lock: Lock for reading/writing the device
+ * @als_data: Pointer to the als data struct
+ * @runtime_ramp_up: Runtime ramp up setting
+ * @runtime_ramp_down: Runtime ramp down setting
+ * @leds: Array of LED strings
  */
 struct lm3532_data {
 	struct gpio_desc *enable_gpio;
-- 
2.28.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH 2/2] leds: lm36274: Fix warning for undefined parameters
  2020-09-22 19:06 [PATCH 1/2] leds: lm3552: Fix warnings for undefined parameters Dan Murphy
@ 2020-09-22 19:06 ` Dan Murphy
  2020-09-23 13:10   ` Marek Behún
  2020-09-24 12:19   ` Pavel Machek
  2020-09-23 13:14 ` [PATCH 1/2] leds: lm3552: Fix warnings " Marek Behun
  1 sibling, 2 replies; 6+ messages in thread
From: Dan Murphy @ 2020-09-22 19:06 UTC (permalink / raw)
  To: pavel; +Cc: linux-leds, linux-kernel, marek.behun, Dan Murphy

Fix warnings for undefined parameters when building with W=1.

Fixes: 11e1bbc116a75 ("leds: lm36274: Introduce the TI LM36274 LED driver")
Signed-off-by: Dan Murphy <dmurphy@ti.com>
---
 drivers/leds/leds-lm36274.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/leds/leds-lm36274.c b/drivers/leds/leds-lm36274.c
index 10a63b7f2ecc..bf6487e9a1f4 100644
--- a/drivers/leds/leds-lm36274.c
+++ b/drivers/leds/leds-lm36274.c
@@ -26,8 +26,8 @@
  * @lmu_data: Register and setting values for common code
  * @regmap: Devices register map
  * @dev: Pointer to the devices device struct
- * @led_sources - The LED strings supported in this array
- * @num_leds - Number of LED strings are supported in this array
+ * @led_sources: The LED strings supported in this array
+ * @num_leds: Number of LED strings are supported in this array
  */
 struct lm36274 {
 	struct platform_device *pdev;
@@ -163,6 +163,7 @@ static struct platform_driver lm36274_driver = {
 	.probe  = lm36274_probe,
 	.driver = {
 		.name = "lm36274-leds",
+		.of_match_table = of_lm36274_leds_match,
 	},
 };
 module_platform_driver(lm36274_driver)
-- 
2.28.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] leds: lm36274: Fix warning for undefined parameters
  2020-09-22 19:06 ` [PATCH 2/2] leds: lm36274: Fix warning " Dan Murphy
@ 2020-09-23 13:10   ` Marek Behún
  2020-09-24 12:19   ` Pavel Machek
  1 sibling, 0 replies; 6+ messages in thread
From: Marek Behún @ 2020-09-23 13:10 UTC (permalink / raw)
  To: Dan Murphy; +Cc: pavel, linux-leds, linux-kernel

On Tue, 22 Sep 2020 14:06:38 -0500
Dan Murphy <dmurphy@ti.com> wrote:

> Fix warnings for undefined parameters when building with W=1.
> 
> Fixes: 11e1bbc116a75 ("leds: lm36274: Introduce the TI LM36274 LED driver")
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
>  drivers/leds/leds-lm36274.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/leds/leds-lm36274.c b/drivers/leds/leds-lm36274.c
> index 10a63b7f2ecc..bf6487e9a1f4 100644
> --- a/drivers/leds/leds-lm36274.c
> +++ b/drivers/leds/leds-lm36274.c
> @@ -26,8 +26,8 @@
>   * @lmu_data: Register and setting values for common code
>   * @regmap: Devices register map
>   * @dev: Pointer to the devices device struct
> - * @led_sources - The LED strings supported in this array
> - * @num_leds - Number of LED strings are supported in this array
> + * @led_sources: The LED strings supported in this array
> + * @num_leds: Number of LED strings are supported in this array
>   */
>  struct lm36274 {
>  	struct platform_device *pdev;
> @@ -163,6 +163,7 @@ static struct platform_driver lm36274_driver = {
>  	.probe  = lm36274_probe,
>  	.driver = {
>  		.name = "lm36274-leds",
> +		.of_match_table = of_lm36274_leds_match,
>  	},
>  };
>  module_platform_driver(lm36274_driver)

Reviewed-by: Marek Behún <kabel@kernel.org>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] leds: lm3552: Fix warnings for undefined parameters
  2020-09-22 19:06 [PATCH 1/2] leds: lm3552: Fix warnings for undefined parameters Dan Murphy
  2020-09-22 19:06 ` [PATCH 2/2] leds: lm36274: Fix warning " Dan Murphy
@ 2020-09-23 13:14 ` Marek Behun
  2020-09-24 12:20   ` Pavel Machek
  1 sibling, 1 reply; 6+ messages in thread
From: Marek Behun @ 2020-09-23 13:14 UTC (permalink / raw)
  To: Dan Murphy; +Cc: pavel, linux-leds, linux-kernel

Wrong subject, it says
  lm3552
but driver is called
  lm3532

Besides this:

Reviewed-by: Marek Behún <kabel@kernel.org>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] leds: lm36274: Fix warning for undefined parameters
  2020-09-22 19:06 ` [PATCH 2/2] leds: lm36274: Fix warning " Dan Murphy
  2020-09-23 13:10   ` Marek Behún
@ 2020-09-24 12:19   ` Pavel Machek
  1 sibling, 0 replies; 6+ messages in thread
From: Pavel Machek @ 2020-09-24 12:19 UTC (permalink / raw)
  To: Dan Murphy; +Cc: linux-leds, linux-kernel, marek.behun

[-- Attachment #1: Type: text/plain, Size: 1614 bytes --]

On Tue 2020-09-22 14:06:38, Dan Murphy wrote:
> Fix warnings for undefined parameters when building with W=1.
>

It also adds of_match_table. I guess that's okay.

I'll remove the fixes tags as I don't believe these need to go to
stable.

Best regards,
								Pavel
     

> Fixes: 11e1bbc116a75 ("leds: lm36274: Introduce the TI LM36274 LED driver")
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
>  drivers/leds/leds-lm36274.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/leds/leds-lm36274.c b/drivers/leds/leds-lm36274.c
> index 10a63b7f2ecc..bf6487e9a1f4 100644
> --- a/drivers/leds/leds-lm36274.c
> +++ b/drivers/leds/leds-lm36274.c
> @@ -26,8 +26,8 @@
>   * @lmu_data: Register and setting values for common code
>   * @regmap: Devices register map
>   * @dev: Pointer to the devices device struct
> - * @led_sources - The LED strings supported in this array
> - * @num_leds - Number of LED strings are supported in this array
> + * @led_sources: The LED strings supported in this array
> + * @num_leds: Number of LED strings are supported in this array
>   */
>  struct lm36274 {
>  	struct platform_device *pdev;
> @@ -163,6 +163,7 @@ static struct platform_driver lm36274_driver = {
>  	.probe  = lm36274_probe,
>  	.driver = {
>  		.name = "lm36274-leds",
> +		.of_match_table = of_lm36274_leds_match,
>  	},
>  };
>  module_platform_driver(lm36274_driver)
> -- 
> 2.28.0

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] leds: lm3552: Fix warnings for undefined parameters
  2020-09-23 13:14 ` [PATCH 1/2] leds: lm3552: Fix warnings " Marek Behun
@ 2020-09-24 12:20   ` Pavel Machek
  0 siblings, 0 replies; 6+ messages in thread
From: Pavel Machek @ 2020-09-24 12:20 UTC (permalink / raw)
  To: Marek Behun; +Cc: Dan Murphy, linux-leds, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 388 bytes --]

On Wed 2020-09-23 15:14:43, Marek Behun wrote:
> Wrong subject, it says
>   lm3552
> but driver is called
>   lm3532
> 
> Besides this:
> 
> Reviewed-by: Marek Behún <kabel@kernel.org>

Thanks for review!

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-09-24 12:20 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-22 19:06 [PATCH 1/2] leds: lm3552: Fix warnings for undefined parameters Dan Murphy
2020-09-22 19:06 ` [PATCH 2/2] leds: lm36274: Fix warning " Dan Murphy
2020-09-23 13:10   ` Marek Behún
2020-09-24 12:19   ` Pavel Machek
2020-09-23 13:14 ` [PATCH 1/2] leds: lm3552: Fix warnings " Marek Behun
2020-09-24 12:20   ` Pavel Machek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).