From: Alexander Mikhalitsyn <alexander.mikhalitsyn@virtuozzo.com>
To: viro@zeniv.linux.org.uk
Cc: avagin@gmail.com,
Alexander Mikhalitsyn <alexander.mikhalitsyn@virtuozzo.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/1] fsopen: fsconfig syscall restart fix
Date: Wed, 23 Sep 2020 19:46:35 +0300 [thread overview]
Message-ID: <20200923164637.13032-1-alexander.mikhalitsyn@virtuozzo.com> (raw)
Hi guys!
Sometimes ago our CRIU CI started reporting hardly-reproducible (on developer
environment) error "EBUSY" from fsconfig syscall in the CRIU cgroups code.
https://github.com/checkpoint-restore/criu/blob/criu-dev/criu/cgroup.c#L585
The machine on which we caught this problem is PowerPC (POWER8). After tracing
and debugging that we realized that problem is that we get ERESTARTNOINR
from vfs_get_tree function in vfs_fsconfig_locked. After a more deep
investigation, we found that the source is cgroup1_get_tree() and
restart_syscall() at the end. I personally have no idea why we caught this only
on POWER8 VM and have no such problem on amd64. But anyway this is incorrect
behaviour and our patch should fix this problem and make this impossible on all
architectures.
Big thanks to Andrei Vagin. He helped me a lot to fully understand the
problem and prepare this patch.
Regards, Alex
Alexander Mikhalitsyn (1):
fsopen: fsconfig syscall restart fix
fs/fsopen.c | 32 +++++++++++++++++++++++++++++++-
1 file changed, 31 insertions(+), 1 deletion(-)
--
2.25.1
next reply other threads:[~2020-09-23 17:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 16:46 Alexander Mikhalitsyn [this message]
2020-09-23 16:46 ` [PATCH 1/1] fsopen: fsconfig syscall restart fix Alexander Mikhalitsyn
2020-09-23 17:03 ` Al Viro
2020-09-23 17:19 ` Alexander Mikhalitsyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200923164637.13032-1-alexander.mikhalitsyn@virtuozzo.com \
--to=alexander.mikhalitsyn@virtuozzo.com \
--cc=avagin@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).