From: Matthias Kaehlcke <mka@chromium.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
linux-kernel@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>,
Alan Stern <stern@rowland.harvard.edu>,
linux-usb@vger.kernel.org, Bastien Nocera <hadess@hadess.net>,
Krzysztof Kozlowski <krzk@kernel.org>,
devicetree@vger.kernel.org,
Ravi Chandra Sadineni <ravisadineni@chromium.org>,
Peter Chen <peter.chen@nxp.com>,
Stephen Boyd <swboyd@chromium.org>,
"Alexander A. Klimov" <grandmaster@al2klimov.de>,
Masahiro Yamada <masahiroy@kernel.org>
Subject: Re: [PATCH v2 2/2] USB: misc: Add onboard_usb_hub driver
Date: Wed, 23 Sep 2020 15:25:45 -0700 [thread overview]
Message-ID: <20200923222545.GB2105328@google.com> (raw)
In-Reply-To: <20200922011837.GE21107@google.com>
On Mon, Sep 21, 2020 at 06:18:37PM -0700, Matthias Kaehlcke wrote:
> On Sun, Sep 20, 2020 at 04:17:20PM +0200, Greg Kroah-Hartman wrote:
> > On Thu, Sep 17, 2020 at 11:46:22AM -0700, Matthias Kaehlcke wrote:
> > >
> > > ...
> > >
> > > +static int __init onboard_hub_init(void)
> > > +{
> > > + int rc;
> > > +
> > > + rc = platform_driver_register(&onboard_hub_driver);
> > > + if (rc)
> > > + return rc;
> > > +
> > > + return usb_register_device_driver(&onboard_hub_usbdev_driver, THIS_MODULE);
> >
> > No unwinding of the platform driver register if this fails?
>
> Right, will add unwinding.
>
> > And THIS_MODULE should not be needed, did we get the api wrong here?
>
> It seems you suggest to use usb_register() instead, SGTM
Actually usb_register() is for registering a struct usb_driver, however
this is a struct usb_device_driver, there doesn't seem to be a
registration function/macro that doesn't require THIS_MODULE. Please
provide a pointer if I'm wrong.
next prev parent reply other threads:[~2020-09-23 22:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 18:46 [PATCH v2 1/2] dt-bindings: usb: Add binding for onboard USB hubs Matthias Kaehlcke
2020-09-17 18:46 ` [PATCH v2 2/2] USB: misc: Add onboard_usb_hub driver Matthias Kaehlcke
2020-09-17 19:54 ` Alan Stern
2020-09-22 0:41 ` Matthias Kaehlcke
2020-09-22 1:08 ` Alan Stern
2020-09-22 1:25 ` Matthias Kaehlcke
2020-09-18 1:30 ` Peter Chen
2020-09-22 0:57 ` Matthias Kaehlcke
2020-09-20 14:17 ` Greg Kroah-Hartman
2020-09-22 1:18 ` Matthias Kaehlcke
2020-09-23 22:25 ` Matthias Kaehlcke [this message]
2020-09-24 6:36 ` Greg Kroah-Hartman
2020-09-18 17:30 ` [PATCH v2 1/2] dt-bindings: usb: Add binding for onboard USB hubs Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200923222545.GB2105328@google.com \
--to=mka@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=frowand.list@gmail.com \
--cc=grandmaster@al2klimov.de \
--cc=gregkh@linuxfoundation.org \
--cc=hadess@hadess.net \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=peter.chen@nxp.com \
--cc=ravisadineni@chromium.org \
--cc=robh+dt@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).