linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Joel Becker <jlbec@evilplan.org>, Christoph Hellwig <hch@lst.de>
Cc: linux-kernel@vger.kernel.org,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: [PATCH 04/12] samples: configfs: drop unnecessary ternary operators
Date: Thu, 24 Sep 2020 14:45:18 +0200	[thread overview]
Message-ID: <20200924124526.17365-5-brgl@bgdev.pl> (raw)
In-Reply-To: <20200924124526.17365-1-brgl@bgdev.pl>

From: Bartosz Golaszewski <bgolaszewski@baylibre.com>

Checking pointers for NULL value before passing them to container_of()
is pointless because even if we return NULL from the ternary operator,
none of the users checks the returned value but they instead dereference
it unconditionally. AFAICT this cannot really happen either. Simplify
the code by removing the ternary operators from to_childless() et al.

Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
 samples/configfs/configfs_sample.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/samples/configfs/configfs_sample.c b/samples/configfs/configfs_sample.c
index d3370180bcce..e339404dce1c 100644
--- a/samples/configfs/configfs_sample.c
+++ b/samples/configfs/configfs_sample.c
@@ -37,8 +37,8 @@ struct childless {
 
 static inline struct childless *to_childless(struct config_item *item)
 {
-	return item ? container_of(to_configfs_subsystem(to_config_group(item)),
-			struct childless, subsys) : NULL;
+	return container_of(to_configfs_subsystem(to_config_group(item)),
+			    struct childless, subsys);
 }
 
 static ssize_t childless_showme_show(struct config_item *item, char *page)
@@ -132,7 +132,7 @@ struct simple_child {
 
 static inline struct simple_child *to_simple_child(struct config_item *item)
 {
-	return item ? container_of(item, struct simple_child, item) : NULL;
+	return container_of(item, struct simple_child, item);
 }
 
 static ssize_t simple_child_storeme_show(struct config_item *item, char *page)
@@ -187,8 +187,8 @@ struct simple_children {
 
 static inline struct simple_children *to_simple_children(struct config_item *item)
 {
-	return item ? container_of(to_config_group(item),
-			struct simple_children, group) : NULL;
+	return container_of(to_config_group(item),
+			    struct simple_children, group);
 }
 
 static struct config_item *simple_children_make_item(struct config_group *group,
-- 
2.17.1


  parent reply	other threads:[~2020-09-24 12:46 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-24 12:45 [PATCH 00/12] samples: configfs: refactor the configfs sample code Bartosz Golaszewski
2020-09-24 12:45 ` [PATCH 01/12] MAINTAINERS: add the sample directory to the configfs entry Bartosz Golaszewski
2020-09-24 12:45 ` [PATCH 02/12] samples: configfs: order includes alphabetically Bartosz Golaszewski
2020-10-07 13:43   ` Christoph Hellwig
2020-10-08 13:23     ` Bartosz Golaszewski
2020-10-08 14:05       ` Christoph Hellwig
2020-09-24 12:45 ` [PATCH 03/12] samples: configfs: remove redundant newlines Bartosz Golaszewski
2020-09-24 12:45 ` Bartosz Golaszewski [this message]
2020-09-24 12:45 ` [PATCH 05/12] samples: configfs: improve alignment of broken lines Bartosz Golaszewski
2020-10-07 13:44   ` Christoph Hellwig
2020-09-24 12:45 ` [PATCH 06/12] samples: configfs: fix alignment in item struct Bartosz Golaszewski
2020-09-24 12:45 ` [PATCH 07/12] samples: configfs: replace simple_strtoul() with kstrtoint() Bartosz Golaszewski
2020-09-24 12:45 ` [PATCH 08/12] samples: configfs: don't reinitialize variables which are already zeroed Bartosz Golaszewski
2020-09-24 12:45 ` [PATCH 09/12] samples: configfs: prefer sizeof(*var) to sizeof(struct var_type) Bartosz Golaszewski
2020-10-07 13:46   ` Christoph Hellwig
2020-09-24 12:45 ` [PATCH 10/12] samples: configfs: consolidate local variables of the same type Bartosz Golaszewski
2020-09-24 12:45 ` [PATCH 11/12] samples: configfs: don't use spaces before tabs Bartosz Golaszewski
2020-09-24 12:45 ` [PATCH 12/12] samples: configfs: prefer pr_err() over bare printk(KERN_ERR Bartosz Golaszewski
2020-10-06 10:40 ` [PATCH 00/12] samples: configfs: refactor the configfs sample code Bartosz Golaszewski
2020-10-07 13:46   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200924124526.17365-5-brgl@bgdev.pl \
    --to=brgl@bgdev.pl \
    --cc=bgolaszewski@baylibre.com \
    --cc=hch@lst.de \
    --cc=jlbec@evilplan.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).