From: Simon Horman <horms@verge.net.au>
To: "longguang.yue" <bigclouds@163.com>
Cc: Wensong Zhang <wensong@linux-vs.org>,
Julian Anastasov <ja@ssi.bg>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
Florian Westphal <fw@strlen.de>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, lvs-devel@vger.kernel.org,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipvs: adjust the debug order of src and dst
Date: Thu, 24 Sep 2020 17:55:50 +0200 [thread overview]
Message-ID: <20200924155550.GC13127@vergenet.net> (raw)
In-Reply-To: <20200923055000.82748-1-bigclouds@163.com>
On Wed, Sep 23, 2020 at 01:49:59PM +0800, longguang.yue wrote:
> From: ylg <bigclouds@163.com>
>
> adjust the debug order of src and dst when tcp state changes
>
> Signed-off-by: ylg <bigclouds@163.com>
Hi,
This sounds reasonable to me but please provide your real name
in the Signed-off-by name, which should be consistent with the From field
at the top of the commit message (or, if absent of the email).
Thanks!
> ---
> net/netfilter/ipvs/ip_vs_proto_tcp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/netfilter/ipvs/ip_vs_proto_tcp.c b/net/netfilter/ipvs/ip_vs_proto_tcp.c
> index dc2e7da2742a..6567eb45a234 100644
> --- a/net/netfilter/ipvs/ip_vs_proto_tcp.c
> +++ b/net/netfilter/ipvs/ip_vs_proto_tcp.c
> @@ -548,10 +548,10 @@ set_tcp_state(struct ip_vs_proto_data *pd, struct ip_vs_conn *cp,
> th->fin ? 'F' : '.',
> th->ack ? 'A' : '.',
> th->rst ? 'R' : '.',
> - IP_VS_DBG_ADDR(cp->daf, &cp->daddr),
> - ntohs(cp->dport),
> IP_VS_DBG_ADDR(cp->af, &cp->caddr),
> ntohs(cp->cport),
> + IP_VS_DBG_ADDR(cp->daf, &cp->daddr),
> + ntohs(cp->dport),
> tcp_state_name(cp->state),
> tcp_state_name(new_state),
> refcount_read(&cp->refcnt));
> --
> 2.20.1 (Apple Git-117)
>
next prev parent reply other threads:[~2020-09-24 15:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 5:49 [PATCH] ipvs: adjust the debug order of src and dst longguang.yue
2020-09-24 15:55 ` Simon Horman [this message]
2020-09-23 6:06 yue longguang
2020-09-23 12:07 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200924155550.GC13127@vergenet.net \
--to=horms@verge.net.au \
--cc=bigclouds@163.com \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=ja@ssi.bg \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).