From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFFA8C4727D for ; Thu, 24 Sep 2020 16:04:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9558823600 for ; Thu, 24 Sep 2020 16:04:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728659AbgIXQE5 (ORCPT ); Thu, 24 Sep 2020 12:04:57 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:53476 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728641AbgIXQE4 (ORCPT ); Thu, 24 Sep 2020 12:04:56 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kLTjj-00G2v0-4T; Thu, 24 Sep 2020 18:04:47 +0200 Date: Thu, 24 Sep 2020 18:04:47 +0200 From: Andrew Lunn To: Paul Menzel Cc: Kai-Heng Feng , Jeff Kirsher , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, Jakub Kicinski , "David S. Miller" Subject: Re: [Intel-wired-lan] [PATCH v2] e1000e: Increase iteration on polling MDIC ready bit Message-ID: <20200924160447.GD3821492@lunn.ch> References: <20200923074751.10527-1-kai.heng.feng@canonical.com> <20200924150958.18016-1-kai.heng.feng@canonical.com> <748efbf9-573f-ab2a-0c82-a7b2a11cda60@molgen.mpg.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <748efbf9-573f-ab2a-0c82-a7b2a11cda60@molgen.mpg.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 24, 2020 at 05:32:12PM +0200, Paul Menzel wrote: > Dear Kai-Heng, > > > Thank you for sending version 2. > > Am 24.09.20 um 17:09 schrieb Kai-Heng Feng: > > We are seeing the following error after S3 resume: > > I’d be great if you added the system and used hardware, you are seeing this > with. > > > [ 704.746874] e1000e 0000:00:1f.6 eno1: Setting page 0x6020 > > [ 704.844232] e1000e 0000:00:1f.6 eno1: MDI Write did not complete > > A follow-up patch, should extend the message to include the timeout value. > > > MDI Write did not complete did not complete in … seconds. > > According to the Linux timestamps it’s 98 ms, which makes sense, as (640 * 3 > * 50 μs = 96 ms). > > What crappy hardware is this, that it takes longer than 100 ms? I'm speculating, but i guess this happens with just the first couple of transfers after power up. After that, it probably takes a single loop. It would be good to see some profile data for this. Completely different MDIO driver and implementation, but this patch might give some ideas how to do the profiling: https://github.com/lunn/linux/commit/76c7810a7e2c1b1e28a7a95d08dd440a8f48a516 Look at the debugfs and num_loops/us parts. Andrew