From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FB2CC4741F for ; Fri, 25 Sep 2020 09:00:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F44420717 for ; Fri, 25 Sep 2020 09:00:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727608AbgIYJAh (ORCPT ); Fri, 25 Sep 2020 05:00:37 -0400 Received: from mga07.intel.com ([134.134.136.100]:19406 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727044AbgIYJAh (ORCPT ); Fri, 25 Sep 2020 05:00:37 -0400 IronPort-SDR: 7OjYIsobAf/PLluLcJdrFiB8zVVyYx/FUIJdbN++1YmgTkm5vYFj+AGXJOAkCjH/e+41BF2d/L CVuK6PRouY1g== X-IronPort-AV: E=McAfee;i="6000,8403,9754"; a="225621530" X-IronPort-AV: E=Sophos;i="5.77,301,1596524400"; d="scan'208";a="225621530" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2020 02:00:36 -0700 IronPort-SDR: ILA4FS7fJgpNARCSc58njc14jCnhe09EWCz0ihD1wqPoQ8WeuTcHl89HM/ac6imOfHomH7wyYo mFHomaURuJ3Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,301,1596524400"; d="scan'208";a="339420923" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga008.jf.intel.com with ESMTP; 25 Sep 2020 02:00:34 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kLjag-001sVF-NX; Fri, 25 Sep 2020 12:00:30 +0300 Date: Fri, 25 Sep 2020 12:00:30 +0300 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Linus Walleij , Jonathan Corbet , Kent Gibson , linux-gpio@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH 7/9] gpio: mockup: pass the chip label as device property Message-ID: <20200925090030.GY3956970@smile.fi.intel.com> References: <20200924113842.11670-1-brgl@bgdev.pl> <20200924113842.11670-8-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200924113842.11670-8-brgl@bgdev.pl> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 24, 2020 at 01:38:40PM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > While we do check the "chip-name" property in probe(), we never actually > use it. Let's pass the chip label to the driver using device properties > as we'll want to allow users to define their own once dynamically > created chips are supported. > > The property is renamed to "chip-label" to not cause any confusion with > the actual chip name which is of the form: "gpiochipX". > > If the "chip-label" property is missing, let's do what most devices in > drivers/gpio/ do and use dev_name(). ... > + properties[prop++] = PROPERTY_ENTRY_STRING("chip-label", > + chip_label); Forgot to update GPIO_MOCKUP_MAX_PROP? > base = gpio_mockup_range_base(i); > if (base >= 0) > properties[prop++] = PROPERTY_ENTRY_U32("gpio-base", -- With Best Regards, Andy Shevchenko