From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 279B0C4727C for ; Fri, 25 Sep 2020 10:59:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E820721D91 for ; Fri, 25 Sep 2020 10:59:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728112AbgIYK72 (ORCPT ); Fri, 25 Sep 2020 06:59:28 -0400 Received: from mga12.intel.com ([192.55.52.136]:23212 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727201AbgIYK72 (ORCPT ); Fri, 25 Sep 2020 06:59:28 -0400 IronPort-SDR: NxroqJBFnnOG0SFW3jmr9GKFyorfexNZB+JKju4FRognpdMttbMXfIhW1gJIebzjfJDEiskCOk LAr0eFTqlESw== X-IronPort-AV: E=McAfee;i="6000,8403,9754"; a="140910441" X-IronPort-AV: E=Sophos;i="5.77,301,1596524400"; d="scan'208";a="140910441" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2020 03:59:27 -0700 IronPort-SDR: I5PGiilFQF4L2sIUVMB4EfcoM1xknhrv4qaJz1wLIa/x3ZofETSD99S2oTQ8tldgMaTF0/cdIi u3Af3IHcWobg== X-IronPort-AV: E=Sophos;i="5.77,301,1596524400"; d="scan'208";a="487421891" Received: from tjhenson-mobl.amr.corp.intel.com (HELO localhost) ([10.252.48.117]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2020 03:59:21 -0700 Date: Fri, 25 Sep 2020 13:59:18 +0300 From: Jarkko Sakkinen To: Borislav Petkov Cc: Sean Christopherson , x86@kernel.org, linux-sgx@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Lutomirski , Jethro Beekman , Cedric Xing , akpm@linux-foundation.org, andriy.shevchenko@linux.intel.com, asapek@google.com, chenalexchen@google.com, conradparker@google.com, cyhanish@google.com, dave.hansen@intel.com, haitao.huang@intel.com, josh@joshtriplett.org, kai.huang@intel.com, kai.svahn@intel.com, kmoy@google.com, ludloff@google.com, luto@kernel.org, nhorman@redhat.com, npmccallum@redhat.com, puiterwijk@redhat.com, rientjes@google.com, tglx@linutronix.de, yaozhangx@google.com Subject: Re: [PATCH v38 21/24] x86/vdso: Implement a vDSO for Intel SGX enclave call Message-ID: <20200925105918.GB180915@linux.intel.com> References: <20200915112842.897265-1-jarkko.sakkinen@linux.intel.com> <20200915112842.897265-22-jarkko.sakkinen@linux.intel.com> <20200924180407.GO5030@zn.tnic> <20200925003808.GB20333@linux.intel.com> <20200925081441.GF16872@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200925081441.GF16872@zn.tnic> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 25, 2020 at 10:14:41AM +0200, Borislav Petkov wrote: > > > > +#define SGX_ENCLAVE_RUN_EXCEPTION 4*8 > > > > + > > > > +#define SGX_SYNCHRONOUS_EXIT 0 > > > > +#define SGX_EXCEPTION_EXIT 1 > > > > > > Those are in ...uapi/asm/sgx.h too. Unify? > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > What about this here? Repeating myself, but since there is only 0 and 1, I would just use 0 and 1. Otherwise, I think I pretty much got these comments sorted out. /Jarkko