From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F4B8C4727D for ; Fri, 25 Sep 2020 12:55:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5783A21741 for ; Fri, 25 Sep 2020 12:55:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601038517; bh=FsSVpHTo1XbS9P5HsjotCNgykMvxFWhHiexMQkxD/hM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=JI6nv6n2Lw3DpU6OAKc8h1s7vKurf712nL0SKQJANXljwxa4Ij9wRZ3LRHOVKB++r jkjATTaSa9QYmFEZc2c97arTqNDgQX+EdFFc+htWBsGmykhqKVjN7J8Zon75v57EsQ 9FaurRUdgmPiJZMgGl+8VpeNzLl0g3Pquwcdiqkg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726990AbgIYMzP (ORCPT ); Fri, 25 Sep 2020 08:55:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:34412 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729260AbgIYMzG (ORCPT ); Fri, 25 Sep 2020 08:55:06 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8FAC62072E; Fri, 25 Sep 2020 12:55:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601038506; bh=FsSVpHTo1XbS9P5HsjotCNgykMvxFWhHiexMQkxD/hM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UZRXbzUvysqD4SxbKAXx4fKHBnJ/LKH25K4HslYEdXoaGq4NfhSM5Vzutr26jll5v uHKUkyFSvXHugyInIN7UTxXGTADZyFdK31dE756l8Nz3/VItQb3dPTlPZyGyeY15QQ 1invxtL6Swn2izs4VAEWO+UZOMLd4rXSt8RP+Tzk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jakub Kicinski , Simon Horman , Jesse Brandeburg , "David S. Miller" Subject: [PATCH 4.19 14/37] nfp: use correct define to return NONE fec Date: Fri, 25 Sep 2020 14:48:42 +0200 Message-Id: <20200925124723.108622514@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200925124720.972208530@linuxfoundation.org> References: <20200925124720.972208530@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jakub Kicinski [ Upstream commit 5f6857e808a8bd078296575b417c4b9d160b9779 ] struct ethtool_fecparam carries bitmasks not bit numbers. We want to return 1 (NONE), not 0. Fixes: 0d0870938337 ("nfp: implement ethtool FEC mode settings") Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman Reviewed-by: Jesse Brandeburg Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c @@ -744,8 +744,8 @@ nfp_port_get_fecparam(struct net_device struct nfp_eth_table_port *eth_port; struct nfp_port *port; - param->active_fec = ETHTOOL_FEC_NONE_BIT; - param->fec = ETHTOOL_FEC_NONE_BIT; + param->active_fec = ETHTOOL_FEC_NONE; + param->fec = ETHTOOL_FEC_NONE; port = nfp_port_from_netdev(netdev); eth_port = nfp_port_get_eth_port(port);