From: Jonathan Cameron <jic23@kernel.org>
To: Cristian Pop <cristian.pop@analog.com>
Cc: <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v6 4/4] dt-bindings:iio:adc:adi,ad7768-1: Add documentation for channel label
Date: Fri, 25 Sep 2020 13:04:56 +0100 [thread overview]
Message-ID: <20200925130456.1203ba5d@archlinux> (raw)
In-Reply-To: <20200921133020.62978-4-cristian.pop@analog.com>
On Mon, 21 Sep 2020 16:30:20 +0300
Cristian Pop <cristian.pop@analog.com> wrote:
Hi Cristian,
> Optional attribute for better identification of the channels.
Dt-bindings need to be sent to the dt-binding maintainer and
list.
+CC.
I'll definitely be looking for a review from Rob on this one as we are defining
a new generic binding.
@Rob, the only new bit in here is the label for an individual channel.
The rest has been defined for a while to allow us to control channel
specific aspects of an ADC.
We should also look to add it to the top level docs.
In this case, probably
Documentation/device-tree/bindings/iio/adc/adc.txt
Currently only ADCs have a channel description to add this to.
We can look at making this more generic if it turns out to make sense
for other types of IIO device.
Thanks,
Jonathan
>
> Signed-off-by: Cristian Pop <cristian.pop@analog.com>
> ---
> .../bindings/iio/adc/adi,ad7768-1.yaml | 31 +++++++++++++++++++
> 1 file changed, 31 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7768-1.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7768-1.yaml
> index d3733ad8785a..0c75ce73ffe9 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7768-1.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7768-1.yaml
> @@ -29,6 +29,12 @@ properties:
> interrupts:
> maxItems: 1
>
> + '#address-cells':
> + const: 1
> +
> + '#size-cells':
> + const: 0
> +
> vref-supply:
> description:
> ADC reference voltage supply
> @@ -61,6 +67,23 @@ required:
> - spi-cpha
> - adi,sync-in-gpios
>
> +patternProperties:
> + "^channel@([0-9]|1[0-5])$":
> + type: object
> + description: |
> + Represents the external channels which are connected to the device.
> +
> + properties:
> + reg:
> + description: |
> + The channel number.
> +
> + label:
> + description: |
> + Unique name to identify which channel this is.
> + required:
> + - rega
rega? Also, one I learnt the other day. Need to have
additionalProperties: false
for child nodes as well as the base node.
> +
> additionalProperties: false
>
> examples:
> @@ -84,6 +107,14 @@ examples:
> reset-gpios = <&gpio 27 GPIO_ACTIVE_LOW>;
> clocks = <&ad7768_mclk>;
> clock-names = "mclk";
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + channel@0 {
> + reg = <0>;
> + label = "channel_0";
> + };
> };
> };
> ...
next prev parent reply other threads:[~2020-09-25 12:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 13:30 [PATCH v6 1/4] iio: core: Add optional symbolic label to a device channel Cristian Pop
2020-09-21 13:30 ` [PATCH v6 2/4] iio:Documentation: Add documentation for label channel attribute Cristian Pop
2020-09-25 12:12 ` Jonathan Cameron
2020-09-21 13:30 ` [PATCH v6 3/4] iio: adc: ad7768-1: Add channel labels Cristian Pop
2020-09-21 13:30 ` [PATCH v6 4/4] dt-bindings:iio:adc:adi,ad7768-1: Add documentation for channel label Cristian Pop
2020-09-25 12:04 ` Jonathan Cameron [this message]
2020-09-25 12:13 ` [PATCH v6 1/4] iio: core: Add optional symbolic label to a device channel Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200925130456.1203ba5d@archlinux \
--to=jic23@kernel.org \
--cc=cristian.pop@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).