From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 498ADC4363D for ; Fri, 25 Sep 2020 14:09:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B6D120936 for ; Fri, 25 Sep 2020 14:09:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UWcWtzyK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729053AbgIYOJl (ORCPT ); Fri, 25 Sep 2020 10:09:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728451AbgIYOJl (ORCPT ); Fri, 25 Sep 2020 10:09:41 -0400 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FED7C0613CE for ; Fri, 25 Sep 2020 07:09:41 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id 197so2677075pge.8 for ; Fri, 25 Sep 2020 07:09:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0g8As1BPIW+mxp09I9Q/3/lncjQOHPnfpBrzGk+edKs=; b=UWcWtzyKjvHUBFmX+yhHW/yzowiin/IE5KGdd9A9mJKNGdDMQPVpfZWbIJit7hr4Ii LSsbh0EJRpzbmjqDq2U2BXsUs9RnW8JGWTXlB2mk3MRInsiepQ1z7o4/IDVMTiratAsU weSnab8KXLNz/OXx2tBkWtU754BxNmim+LlybEjrGoMoBc8ct2yLIxjo407rNnWuFYX1 yWYvYx2Kar/duQcN3ybLb3t2rX7k/S180EdAJUaThcxxAKOJQ4Lcvd6wcCRcO/vv3FYG SkVSSJ60+mhJ+Xxx8z80GM3bxdd2DPud8gb0iJsdclNPi99jA9WyLHuEBY4xRkQVoVDJ pCdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0g8As1BPIW+mxp09I9Q/3/lncjQOHPnfpBrzGk+edKs=; b=bLO8VD5SXeDqtHPkMAvq7YlRzbOVhWu2fSL+kNa3xFTZk9TkUxMOlTBvexAH4hUy9B cVUFrNi5wxvQLidfpb8oDN4wbD7SG9PYCo/UjBkYZRsCf9ReMQJ5cSQ57H2WhwSkM8DU NKGUYLExvw33Pe9pNyk0nIHZ709e5gpQ/2FrNvr7Ab93jED+b2UiXbola4D4SeKA9toQ ezJUI6GDYKTfnaSePt10VVIOA6H6gS4tP/fvCn+leJTckKHzqJLtrP7RFINNgi5yYeF1 oDaH/LOA9HHQ9b1fz1HIGbTCccD9OWMjh+ss3WDBDblAvAqbaqbGqdMNSYIv7w0rtYl8 ftoQ== X-Gm-Message-State: AOAM532dekNH8zMgtBh9sGa3PLru35eHXcirZfP3V1BM0qMe+iydrR0E nuxrgr58Liz9JXarenug0Jbxdigzacn+anxr X-Google-Smtp-Source: ABdhPJwk68+UWFlYWcCpKkQ8+c+rYqCmlV6pLOaXJQRxXzB9Dulo4yoG8/DhVauFLxz7iyIvFrtHdw== X-Received: by 2002:a63:c74a:: with SMTP id v10mr207846pgg.240.1601042980847; Fri, 25 Sep 2020 07:09:40 -0700 (PDT) Received: from localhost ([2001:e42:102:1532:160:16:113:140]) by smtp.gmail.com with ESMTPSA id a13sm2416696pgq.41.2020.09.25.07.09.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Sep 2020 07:09:40 -0700 (PDT) From: Coiby Xu X-Google-Original-From: Coiby Xu Date: Fri, 25 Sep 2020 22:09:30 +0800 To: Alex Elder Cc: devel@driverdev.osuosl.org, Alex Elder , open list , Johan Hovold , "moderated list:GREYBUS SUBSYSTEM" , Dan Carpenter Subject: Re: [greybus-dev] [PATCH 1/3] [PATCH] staging: greybus: fix warnings about endianness detected by sparse Message-ID: <20200925140930.z6yvqvm6crrq5k3a@Rk> References: <20200924102039.43895-1-coiby.xu@gmail.com> <3fda9226-6f6f-6c5f-aa02-c9047a3d2dce@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <3fda9226-6f6f-6c5f-aa02-c9047a3d2dce@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 24, 2020 at 07:50:57AM -0500, Alex Elder wrote: >On 9/24/20 5:20 AM, Coiby Xu wrote: >> This patch fix the following warnings from sparse, > >You need to address Greg's comment. > >But in general this looks good. I have one comment below, which >you can address in v2. If you (or others) disagree with it, I'm >fine with your code as-is. Either way, you can add this: > >Reviewed-by: Alex Elder Thank you fore reviewing this patch! > >> $ make C=2 drivers/staging/greybus/ >> drivers/staging/greybus/audio_module.c:222:25: warning: incorrect type in assignment (different base types) >> drivers/staging/greybus/audio_module.c:222:25: expected restricted __le16 [usertype] data_cport >> drivers/staging/greybus/audio_module.c:222:25: got unsigned short [usertype] intf_cport_id >> drivers/staging/greybus/audio_topology.c:460:40: warning: restricted __le32 degrades to integer >> drivers/staging/greybus/audio_topology.c:691:41: warning: incorrect type in assignment (different base types) > >. . . > >> diff --git a/drivers/staging/greybus/audio_topology.c b/drivers/staging/greybus/audio_topology.c >> index 83b38ae8908c..56bf1a4f95ad 100644 >> --- a/drivers/staging/greybus/audio_topology.c >> +++ b/drivers/staging/greybus/audio_topology.c >> @@ -466,7 +466,7 @@ static int gbcodec_mixer_dapm_ctl_put(struct snd_kcontrol *kcontrol, >> goto exit; >> >> /* update ucontrol */ >> - if (gbvalue.value.integer_value[0] != val) { >> + if (gbvalue.value.integer_value[0] != cpu_to_le32(val)) { > >It's equivalent, but I have a small preference to convert >the value from gbvalue into CPU byte order rather than >what you have here. Thank you for the suggestion! I'll use CPU byte order when submitting next version. > >> for (wi = 0; wi < wlist->num_widgets; wi++) { >> widget = wlist->widgets[wi]; >> snd_soc_dapm_mixer_update_power(widget->dapm, kcontrol, >> @@ -689,7 +689,7 @@ static int gbaudio_tplg_create_kcontrol(struct gbaudio_module_info *gb, >> return -ENOMEM; >> ctldata->ctl_id = ctl->id; >> ctldata->data_cport = le16_to_cpu(ctl->data_cport); >> - ctldata->access = ctl->access; >> + ctldata->access = le32_to_cpu(ctl->access); >> ctldata->vcount = ctl->count_values; >> ctldata->info = &ctl->info; >> *kctl = (struct snd_kcontrol_new) >> @@ -744,10 +744,10 @@ static int gbcodec_enum_dapm_ctl_get(struct snd_kcontrol *kcontrol, >> return ret; >> } >> >> - ucontrol->value.enumerated.item[0] = gbvalue.value.enumerated_item[0]; >> + ucontrol->value.enumerated.item[0] = le32_to_cpu(gbvalue.value.enumerated_item[0]); >> if (e->shift_l != e->shift_r) >> ucontrol->value.enumerated.item[1] = >> - gbvalue.value.enumerated_item[1]; >> + le32_to_cpu(gbvalue.value.enumerated_item[1]); >> >> return 0; >> } >> @@ -801,10 +801,10 @@ static int gbcodec_enum_dapm_ctl_put(struct snd_kcontrol *kcontrol, >> mask = e->mask << e->shift_l; >> >> if (gbvalue.value.enumerated_item[0] != >> - ucontrol->value.enumerated.item[0]) { >> + cpu_to_le32(ucontrol->value.enumerated.item[0])) { >> change = 1; >> gbvalue.value.enumerated_item[0] = >> - ucontrol->value.enumerated.item[0]; >> + cpu_to_le32(ucontrol->value.enumerated.item[0]); >> } >> >> if (e->shift_l != e->shift_r) { >> @@ -813,10 +813,10 @@ static int gbcodec_enum_dapm_ctl_put(struct snd_kcontrol *kcontrol, >> val |= ucontrol->value.enumerated.item[1] << e->shift_r; >> mask |= e->mask << e->shift_r; >> if (gbvalue.value.enumerated_item[1] != >> - ucontrol->value.enumerated.item[1]) { >> + cpu_to_le32(ucontrol->value.enumerated.item[1])) { >> change = 1; >> gbvalue.value.enumerated_item[1] = >> - ucontrol->value.enumerated.item[1]; >> + cpu_to_le32(ucontrol->value.enumerated.item[1]); >> } >> } >> >> @@ -887,7 +887,7 @@ static int gbaudio_tplg_create_mixer_ctl(struct gbaudio_module_info *gb, >> return -ENOMEM; >> ctldata->ctl_id = ctl->id; >> ctldata->data_cport = le16_to_cpu(ctl->data_cport); >> - ctldata->access = ctl->access; >> + ctldata->access = le32_to_cpu(ctl->access); >> ctldata->vcount = ctl->count_values; >> ctldata->info = &ctl->info; >> *kctl = (struct snd_kcontrol_new) >> > -- Best regards, Coiby