From: Coiby Xu <coiby.xu@gmail.com>
To: David Laight <David.Laight@aculab.com>
Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
Vaibhav Agarwal <vaibhav.sr@gmail.com>,
Mark Greer <mgreer@animalcreek.com>,
Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
"moderated list:GREYBUS SUBSYSTEM" <greybus-dev@lists.linaro.org>,
open list <linux-kernel@vger.kernel.org>,
"moderated list:SOUND" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH 3/3] [PATCH] staging: greybus: __u8 is sufficient for snd_ctl_elem_type_t and snd_ctl_elem_iface_t
Date: Fri, 25 Sep 2020 22:11:25 +0800 [thread overview]
Message-ID: <20200925141125.vfm5sjnsfvxo2ras@Rk> (raw)
In-Reply-To: <0175c477851243baa8a92177667d6312@AcuMS.aculab.com>
On Thu, Sep 24, 2020 at 10:54:50AM +0000, David Laight wrote:
>From: Coiby Xu
>> Sent: 24 September 2020 11:21
>> Use __8 to replace int and remove the unnecessary __bitwise type attribute.
>>
>> Found by sparse,
>...
>> diff --git a/include/uapi/sound/asound.h b/include/uapi/sound/asound.h
>> index 535a7229e1d9..8e71a95644ab 100644
>> --- a/include/uapi/sound/asound.h
>> +++ b/include/uapi/sound/asound.h
>> @@ -950,7 +950,7 @@ struct snd_ctl_card_info {
>> unsigned char components[128]; /* card components / fine identification, delimited with one
>> space (AC97 etc..) */
>> };
>>
>> -typedef int __bitwise snd_ctl_elem_type_t;
>> +typedef __u8 snd_ctl_elem_type_t;
>> #define SNDRV_CTL_ELEM_TYPE_NONE ((__force snd_ctl_elem_type_t) 0) /* invalid */
>> #define SNDRV_CTL_ELEM_TYPE_BOOLEAN ((__force snd_ctl_elem_type_t) 1) /* boolean type */
>> #define SNDRV_CTL_ELEM_TYPE_INTEGER ((__force snd_ctl_elem_type_t) 2) /* integer type */
>
>WTF is all that about anyway??
>What is wrong with:
>#define SNDRV_CTL_ELEM_TYPE_NONE 0u /* invalid */
I'm sorry I don't quite understand you. Are you suggesting SNDRV_CTL_ELEM_TYPE_NONE
isn't needed in the first place?
>
> David
>
>-
>Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
>Registration No: 1397386 (Wales)
>
--
Best regards,
Coiby
next prev parent reply other threads:[~2020-09-25 14:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 10:20 [PATCH 1/3] [PATCH] staging: greybus: fix warnings about endianness detected by sparse Coiby Xu
2020-09-24 10:20 ` [PATCH 2/3] staging: greybus: codecs: use SNDRV_PCM_FMTBIT_S16_LE for format bitmask Coiby Xu
2020-09-24 12:54 ` [greybus-dev] " Alex Elder
2020-09-24 10:20 ` [PATCH 3/3] [PATCH] staging: greybus: __u8 is sufficient for snd_ctl_elem_type_t and snd_ctl_elem_iface_t Coiby Xu
2020-09-24 10:54 ` David Laight
2020-09-25 14:11 ` Coiby Xu [this message]
2020-09-25 16:02 ` [greybus-dev] " Alex Elder
2020-09-26 4:01 ` Coiby Xu
2020-09-26 10:11 ` David Laight
2020-09-24 11:00 ` Greg Kroah-Hartman
2020-09-25 14:07 ` Coiby Xu
2020-09-25 15:57 ` Alex Elder
2020-09-26 5:09 ` Coiby Xu
2020-09-24 13:01 ` [greybus-dev] " Alex Elder
2020-09-24 12:50 ` [greybus-dev] [PATCH 1/3] [PATCH] staging: greybus: fix warnings about endianness detected by sparse Alex Elder
2020-09-25 14:09 ` Coiby Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200925141125.vfm5sjnsfvxo2ras@Rk \
--to=coiby.xu@gmail.com \
--cc=David.Laight@aculab.com \
--cc=alsa-devel@alsa-project.org \
--cc=devel@driverdev.osuosl.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgreer@animalcreek.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=vaibhav.sr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).