From: Borislav Petkov <bp@alien8.de>
To: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Cc: linux-mm@kvack.org, linux-acpi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, x86@kernel.org,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
rafael@kernel.org, Ingo Molnar <mingo@redhat.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
linuxarm@huawei.com, Dan Williams <dan.j.williams@intel.com>,
Brice Goglin <Brice.Goglin@inria.fr>,
Sean V Kelley <sean.v.kelley@linux.intel.com>,
linux-api@vger.kernel.org, Hanjun Guo <guohanjun@huawei.com>
Subject: Re: [PATCH v10 2/6] x86: Support Generic Initiator only proximity domains
Date: Fri, 25 Sep 2020 18:08:17 +0200 [thread overview]
Message-ID: <20200925160817.GJ16872@zn.tnic> (raw)
In-Reply-To: <20200925123226.0000636a@Huawei.com>
On Fri, Sep 25, 2020 at 12:32:26PM +0100, Jonathan Cameron wrote:
> I don't think we can. This is doing the same operation as
> is done for memoryless cpu nodes in the init_cpu_to_node() call above
> so it would make little sense from a code flow point of view, even if
> it were possible. However it isn't possible as far as I can see.
>
> It is called after init_cpu_to_node() because...
> * A GI node may also be a CPU node and / or a Memory Node, but we only
> have to do anything extra if it has neither of these.
> Easiest way to do that is use the same logic init_cpu_to_node()
> does and rely on ordering wrt to the other two types of nodes that
> have already been handled. We could have could just call it at the
> end of init_cpu_to_node() but I'd not be happy doing so without renaming
> that function and then we'd end up with a horrible name like
> init_cpu_to_node_and_gi() as they are rather different things.
>
> It needs to happen before use is made of the node_data which is allocated
> in init_gi_nodes() / init_memoryless_node() / alloc_node_data()
Let's put the gist of this requirement in the comment above
init_gi_nodes() for future reference.
...
> It might be possible to allocate the zonelists for this special case later
> in the boot flow, but it seems like we would be adding a lot of complexity
> to avoid a single function call.
Nah, probably not worth the hassle.
> How about this?
>
> +/*
> + * A node may exist which has one or more Generic Initiators but no
> + * CPUs and no memory.
> + * When this function is called, any nodes containing either memory
> + * and/or CPUs will already be online and there is no need to do
> + * anything extra, even if they also contain one or more Generic
> + * Initiators.
> + */
Yes, along with the above gist.
Thx!
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-09-25 16:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 14:03 [PATCH v10 0/6] ACPI: Support Generic Initiator proximity domains Jonathan Cameron
2020-09-07 14:03 ` [PATCH v10 1/6] ACPI: Support Generic Initiator only domains Jonathan Cameron
2020-09-07 14:03 ` [PATCH v10 2/6] x86: Support Generic Initiator only proximity domains Jonathan Cameron
2020-09-23 16:06 ` Borislav Petkov
2020-09-25 11:32 ` Jonathan Cameron
2020-09-25 16:08 ` Borislav Petkov [this message]
2020-09-07 14:03 ` [PATCH v10 3/6] ACPI: Let ACPI know we support Generic Initiator Affinity Structures Jonathan Cameron
2020-09-07 14:03 ` [PATCH v10 4/6] ACPI: HMAT: Fix handling of changes from ACPI 6.2 to ACPI 6.3 Jonathan Cameron
2020-09-07 14:03 ` [PATCH v10 5/6] node: Add access1 class to represent CPU to memory characteristics Jonathan Cameron
2020-09-07 14:03 ` [PATCH v10 6/6] docs: mm: numaperf.rst Add brief description for access class 1 Jonathan Cameron
2020-09-18 12:17 ` [PATCH v10 0/6] ACPI: Support Generic Initiator proximity domains Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200925160817.GJ16872@zn.tnic \
--to=bp@alien8.de \
--cc=Brice.Goglin@inria.fr \
--cc=Jonathan.Cameron@Huawei.com \
--cc=bhelgaas@google.com \
--cc=dan.j.williams@intel.com \
--cc=guohanjun@huawei.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxarm@huawei.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=mingo@redhat.com \
--cc=rafael@kernel.org \
--cc=sean.v.kelley@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).