From: Mark Brown <broonie@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH 1/2] ASoC: qdsp6: Drop of_match_ptr to fix -Wunused-const-variable
Date: Fri, 25 Sep 2020 17:17:36 +0100 [thread overview]
Message-ID: <20200925161736.GE4841@sirena.org.uk> (raw)
In-Reply-To: <20200925084925.26926-2-srinivas.kandagatla@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 369 bytes --]
On Fri, Sep 25, 2020 at 09:49:24AM +0100, Srinivas Kandagatla wrote:
> The of_device_id is included unconditionally by of.h header and used
> in the driver as well. Remove of_match_ptr to fix W=1 compile test
> warning with !CONFIG_OF:
It's better to fix this by adding #ifdefs around the table so that we
don't have unneeded bloat from the match table in !OF cases.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-09-25 16:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 8:49 [PATCH 0/2] ASoC: qdsp6: fix some warnings when build without CONFIG_OF Srinivas Kandagatla
2020-09-25 8:49 ` [PATCH 1/2] ASoC: qdsp6: Drop of_match_ptr to fix -Wunused-const-variable Srinivas Kandagatla
2020-09-25 16:17 ` Mark Brown [this message]
2020-09-25 16:24 ` Srinivas Kandagatla
2020-09-25 8:49 ` [PATCH 2/2] ASoC: q6asm: fix kernel doc warnings Srinivas Kandagatla
2020-09-25 20:41 ` [PATCH 0/2] ASoC: qdsp6: fix some warnings when build without CONFIG_OF Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200925161736.GE4841@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=perex@perex.cz \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).