From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: tglx@linutronix.de, mingo@kernel.org,
linux-kernel@vger.kernel.org, qais.yousef@arm.com,
swood@redhat.com, valentin.schneider@arm.com,
juri.lelli@redhat.com, vincent.guittot@linaro.org,
dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, bristot@redhat.com,
vincent.donnefort@arm.com
Subject: Re: [PATCH 0/9] sched: Migrate disable support
Date: Fri, 25 Sep 2020 20:17:27 +0200 [thread overview]
Message-ID: <20200925181727.ryuacrsipyaz65z7@linutronix.de> (raw)
In-Reply-To: <20200921163557.234036895@infradead.org>
On 2020-09-21 18:35:57 [+0200], Peter Zijlstra wrote:
> Hi,
Hi,
> Here's my take on migrate_disable(). It avoids growing a second means of
I have here:
|005: numa_remove_cpu cpu 5 node 0: mask now 0,3-4,6-7
|007: smpboot: CPU 5 is now offline
|006: ------------[ cut here ]------------
|006: rq->balance_callback
|006: WARNING: CPU: 6 PID: 8392 at kernel/sched/sched.h:1234 try_to_wake_up+0x696/0x860
|006: Modules linked in:
|006:
|006: CPU: 6 PID: 8392 Comm: hackbench Not tainted 5.9.0-rc6-rt9+ #60
|006: Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.14.0-1 04/01/2014
|006: RIP: 0010:try_to_wake_up+0x696/0x860
|006: Code: c0 01 00 00 01 e9 d9 fb ff ff 80 3d 90 ef 6d 01 00 0f 85 6c fb ff ff 48 c7 c7 d4 4a 2c 82 c6 05 7c ef 6d 01 01 e8 dd 21 fc ff <0f> 0b e9 52 fb ff ff 0f 0b e9 b2
|006: RSP: 0018:ffffc90005b978f8 EFLAGS: 00010082
|006:
|006: RAX: 0000000000000000 RBX: ffff8882755cca40 RCX: 0000000000000000
|006: RDX: ffffffff8247aab8 RSI: 00000000ffffffff RDI: 00000000ffffffff
|006: RBP: 0000000000000000 R08: 0000000000000001 R09: ffffffff8247a9a0
|006: R10: ffffc90005b97838 R11: 332e39313320205b R12: ffff888276da8600
|006: R13: 0000000000000093 R14: ffff8882755cd7a0 R15: ffff888276da8618
|006: FS: 00007f6fa7805740(0000) GS:ffff888276d80000(0000) knlGS:0000000000000000
|006: CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
|006: CR2: 00007f6fa796af90 CR3: 0000000262588000 CR4: 00000000003506e0
|006: Call Trace:
|006: ? cpu_stop_queue_work+0x8e/0x150
|006: __wake_up_q+0x96/0xc0
|006: cpu_stop_queue_work+0x9a/0x150
|006: finish_task_switch.isra.0+0x2f1/0x460
|006: __schedule+0x3bd/0xb20
|006: schedule+0x4a/0x100
|006: schedule_hrtimeout_range_clock+0x14f/0x160
|006: ? rt_spin_unlock+0x39/0x90
|006: ? rt_mutex_futex_unlock+0xcb/0xe0
|006: poll_schedule_timeout.constprop.0+0x4d/0x90
|006: do_sys_poll+0x314/0x430
|006: ? __lock_acquire+0x39b/0x2010
|006: ? poll_schedule_timeout.constprop.0+0x90/0x90
|006: ? mark_held_locks+0x49/0x70
|006: ? find_held_lock+0x2b/0x80
|006: ? rt_spin_unlock+0x39/0x90
|006: ? rt_mutex_futex_unlock+0xcb/0xe0
|006: ? rt_spin_unlock+0x51/0x90
|006: ? handle_mm_fault+0xfbd/0x1510
|006: ? find_held_lock+0x2b/0x80
|006: ? do_user_addr_fault+0x214/0x420
|006: __x64_sys_poll+0x37/0x130
|006: do_syscall_64+0x33/0x40
|006: entry_SYSCALL_64_after_hwframe+0x44/0xa9
|006: RIP: 0033:0x7f6fa78fb483
Is this somewhere among the fixes Valentin received?
This SCHED_WARN_ON(rq->balance_callback); in rq_pin_lock().
Sebastian
next prev parent reply other threads:[~2020-09-25 18:17 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 16:35 [PATCH 0/9] sched: Migrate disable support Peter Zijlstra
2020-09-21 16:35 ` [PATCH 1/9] stop_machine: Add function and caller debug info Peter Zijlstra
2020-09-21 16:35 ` [PATCH 2/9] sched: Fix balance_callback() Peter Zijlstra
2020-09-23 14:08 ` Thomas Gleixner
2020-09-21 16:36 ` [PATCH 3/9] sched/hotplug: Ensure only per-cpu kthreads run during hotplug Peter Zijlstra
2020-09-25 16:38 ` Dietmar Eggemann
2020-10-02 14:20 ` Peter Zijlstra
2020-09-21 16:36 ` [PATCH 4/9] sched/core: Wait for tasks being pushed away on hotplug Peter Zijlstra
2020-09-21 16:36 ` [PATCH 5/9] sched/hotplug: Consolidate task migration on CPU unplug Peter Zijlstra
2020-10-01 17:12 ` Vincent Donnefort
2020-10-02 14:17 ` Peter Zijlstra
2020-09-21 16:36 ` [PATCH 6/9] sched: Massage set_cpus_allowed Peter Zijlstra
2020-09-23 14:07 ` Thomas Gleixner
2020-09-21 16:36 ` [PATCH 7/9] sched: Add migrate_disable() Peter Zijlstra
2020-09-21 19:16 ` Thomas Gleixner
2020-09-21 20:42 ` Daniel Bristot de Oliveira
2020-09-23 8:31 ` Thomas Gleixner
2020-09-23 10:51 ` Daniel Bristot de Oliveira
2020-09-23 17:08 ` peterz
2020-09-23 17:54 ` Daniel Bristot de Oliveira
2020-09-23 7:48 ` peterz
2020-09-24 11:53 ` Valentin Schneider
2020-09-24 12:29 ` Peter Zijlstra
2020-09-24 12:33 ` Valentin Schneider
2020-09-24 12:35 ` Peter Zijlstra
2020-09-25 16:50 ` Sebastian Andrzej Siewior
2020-10-02 14:21 ` Peter Zijlstra
2020-10-02 14:36 ` Sebastian Andrzej Siewior
2020-09-21 16:36 ` [PATCH 8/9] sched: Fix migrate_disable() vs set_cpus_allowed_ptr() Peter Zijlstra
2020-09-24 19:59 ` Valentin Schneider
2020-09-25 8:43 ` Peter Zijlstra
2020-09-25 10:07 ` Valentin Schneider
2020-09-25 9:05 ` Peter Zijlstra
2020-09-25 9:56 ` Peter Zijlstra
2020-09-25 10:09 ` Valentin Schneider
2020-09-21 16:36 ` [PATCH 9/9] sched/core: Make migrate disable and CPU hotplug cooperative Peter Zijlstra
2020-09-25 9:12 ` [PATCH 0/9] sched: Migrate disable support Dietmar Eggemann
2020-09-25 10:10 ` Peter Zijlstra
2020-09-25 11:58 ` Dietmar Eggemann
2020-09-25 12:19 ` Valentin Schneider
2020-09-25 17:49 ` Valentin Schneider
2020-09-29 9:15 ` Dietmar Eggemann
2020-09-25 18:17 ` Sebastian Andrzej Siewior [this message]
2020-09-25 19:32 ` Valentin Schneider
2020-10-02 14:30 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200925181727.ryuacrsipyaz65z7@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=qais.yousef@arm.com \
--cc=rostedt@goodmis.org \
--cc=swood@redhat.com \
--cc=tglx@linutronix.de \
--cc=valentin.schneider@arm.com \
--cc=vincent.donnefort@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).