From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ABAEC47420 for ; Fri, 25 Sep 2020 18:47:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E7EE420878 for ; Fri, 25 Sep 2020 18:47:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="dRgYAI+I" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729733AbgIYSrR (ORCPT ); Fri, 25 Sep 2020 14:47:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729121AbgIYSrQ (ORCPT ); Fri, 25 Sep 2020 14:47:16 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 039A1C0613D3 for ; Fri, 25 Sep 2020 11:47:16 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id y15so4508774wmi.0 for ; Fri, 25 Sep 2020 11:47:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=g/BH1U9GUunsIrnO/GbdPQWxTeH46s0MtJm8Rv2PmQg=; b=dRgYAI+Il/XnGvkuGcGG/lsBUKoJIpFGsPVq7bdfwYbSWBuKZWhEyZ/C6V2T06d7l+ MlGVte7aAMEe5kn/Xzgvbo6wkmehHB6utltBuTWLjuy10bgK9jfUtimOpRmqNVZ/PDb7 pPEsfddSQturiPpnwk/9j/tF8/GG+ViphzAqQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=g/BH1U9GUunsIrnO/GbdPQWxTeH46s0MtJm8Rv2PmQg=; b=IpZKUWW5zt73+4MUctLukp3cCavN2WscaBb+xij9QYiAqUETFMHHiM8W1YGhz0/zz5 /VKmYbrDnD4sZWwVJPKFVYEsxuLXCtJlsM0Eox0ehGZLklmIAMHgAvz8eJFmMZsJZkyv bRKCoanDvaZFNEWCuuOrZ9RjDQqyYh/JVu5lFI9ipD9OIJi3lENoWcf1/mu7qGdgpTtd MycxWKVMVErxzrYB5vhP650sDiO4LpdHi84x2iiE0/xVaMnCpKmv11q74bv3l/Lta9en CzRNh3OCKC8mEy6+Zduz6IiLhh2fh25L17609cn1qoiaUBeLvgm3rJGHpcL7GH3OH6Hm vZ4w== X-Gm-Message-State: AOAM530gp9wSXGXyBmttFEWPJzeLIIQo2AysxPQpft/W4FN8BBPt9Joa 903tlk6LKvicagphBByBmQ8Lbg== X-Google-Smtp-Source: ABdhPJwizv9lDNCgaSezSHmDHMwhCyQSsePLifiuaYRBnBvcSMHXRWloRU3D/0rZv64JO/qSChFcJg== X-Received: by 2002:a1c:2d86:: with SMTP id t128mr4754086wmt.189.1601059634661; Fri, 25 Sep 2020 11:47:14 -0700 (PDT) Received: from chromium.org (216.131.76.34.bc.googleusercontent.com. [34.76.131.216]) by smtp.gmail.com with ESMTPSA id w15sm3841044wro.46.2020.09.25.11.47.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Sep 2020 11:47:13 -0700 (PDT) Date: Fri, 25 Sep 2020 18:47:12 +0000 From: Tomasz Figa To: Christoph Hellwig Cc: Mauro Carvalho Chehab , Thomas Bogendoerfer , "James E.J. Bottomley" , Joonyoung Shim , Seung-Woo Kim , Ben Skeggs , Marek Szyprowski , Matt Porter , iommu@lists.linux-foundation.org, Stefan Richter , linux1394-devel@lists.sourceforge.net, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, nouveau@lists.freedesktop.org, netdev@vger.kernel.org, linux-scsi@vger.kernel.org, linux-mm@kvack.org, alsa-devel@alsa-project.org, Sergey Senozhatsky Subject: Re: [PATCH 01/18] media/v4l2: remove V4L2-FLAG-MEMORY-NON-CONSISTENT flag Message-ID: <20200925184712.GC3607091@chromium.org> References: <20200915155122.1768241-1-hch@lst.de> <20200915155122.1768241-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200915155122.1768241-2-hch@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Christoph, On Tue, Sep 15, 2020 at 05:51:05PM +0200, Christoph Hellwig wrote: > From: Sergey Senozhatsky > > The patch partially reverts some of the UAPI bits of the buffer > cache management hints. Namely, the queue consistency (memory > coherency) user-space hint because, as it turned out, the kernel > implementation of this feature was misusing DMA_ATTR_NON_CONSISTENT. > > The patch revers both kernel and user space parts: removes the > DMA consistency attr functions, rollbacks changes to v4l2_requestbuffers, > v4l2_create_buffers structures and corresponding UAPI functions > (plus compat32 layer) and cleanups the documentation. > > Signed-off-by: Christoph Hellwig > Signed-off-by: Sergey Senozhatsky > Signed-off-by: Christoph Hellwig > --- > .../userspace-api/media/v4l/buffer.rst | 17 ------- > .../media/v4l/vidioc-create-bufs.rst | 6 +-- > .../media/v4l/vidioc-reqbufs.rst | 12 +---- > .../media/common/videobuf2/videobuf2-core.c | 46 +++---------------- > .../common/videobuf2/videobuf2-dma-contig.c | 19 -------- > .../media/common/videobuf2/videobuf2-dma-sg.c | 3 +- > .../media/common/videobuf2/videobuf2-v4l2.c | 18 +------- > drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 10 +--- > drivers/media/v4l2-core/v4l2-ioctl.c | 5 +- > include/media/videobuf2-core.h | 7 +-- > include/uapi/linux/videodev2.h | 13 +----- > 11 files changed, 22 insertions(+), 134 deletions(-) Acked-by: Tomasz Figa Best regards, Tomasz