From: Axel Rasmussen <axelrasmussen@google.com>
To: Steven Rostedt <rostedt@goodmis.org>, Tom Zanussi <zanussi@kernel.org>
Cc: linux-kernel@vger.kernel.org, Axel Rasmussen <axelrasmussen@google.com>
Subject: [RFC PATCH 0/1] tracing: support dynamic string field types for synthetic events
Date: Fri, 25 Sep 2020 12:08:05 -0700 [thread overview]
Message-ID: <20200925190806.1870935-1-axelrasmussen@google.com> (raw)
Hi Steven and Tom,
In this thread: https://lkml.org/lkml/2020/9/17/1015 we discussed how to plumb
dynamic strings into synthetic events. Tom, you proposed adding a new dynamic
string type to synthetic event definition like "char foo[]".
I'm sending this patch because it may be simpler than implementing that (I'm
not too familiar with the tracing infrastructure, apologies if this is not
true), and in my testing it seems sufficient to address my use case. I tested
both setting up a synthetic event as Steven described in the other thread, as
well as doing an analogous thing with a small bpftrace program, and both work as
expected with this patch.
This is because I happen to know there's an upper bound on the length of the
string in question, so I can just define a "char memcg_path[256]" in the
synthetic event, and I can be sure the string won't be truncated.
Let me know what you think. Happy to drop this and wait for Tom's suggested
approach instead.
Axel Rasmussen (1):
tracing: support dynamic string field types for synthetic events
kernel/trace/trace_events_hist.c | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
--
2.28.0.681.g6f77f65b4e-goog
next reply other threads:[~2020-09-25 20:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 19:08 Axel Rasmussen [this message]
2020-09-25 19:08 ` [RFC PATCH 1/1] tracing: support dynamic string field types for synthetic events Axel Rasmussen
2020-09-25 19:53 ` Tom Zanussi
2020-09-25 19:27 ` [RFC PATCH 0/1] " Steven Rostedt
2020-09-25 19:48 ` Tom Zanussi
2020-09-25 20:57 ` Axel Rasmussen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200925190806.1870935-1-axelrasmussen@google.com \
--to=axelrasmussen@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).