From: Leon Romanovsky <leon@kernel.org>
To: Doug Ledford <dledford@redhat.com>, Jason Gunthorpe <jgg@nvidia.com>
Cc: Leon Romanovsky <leonro@nvidia.com>,
Ariel Levkovich <lariel@mellanox.com>,
Gal Pressman <galpress@amazon.com>,
Leon Romanovsky <leonro@mellanox.com>,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
Mark Zhang <markz@nvidia.com>, Sean Hefty <sean.hefty@intel.com>,
Yishai Hadas <yishaih@nvidia.com>
Subject: [PATCH rdma-next v3 0/9] Track memory allocation with restrack DB help
Date: Sat, 26 Sep 2020 13:19:29 +0300 [thread overview]
Message-ID: <20200926101938.2964394-1-leon@kernel.org> (raw)
From: Leon Romanovsky <leonro@nvidia.com>
Changelog:
v3:
* Rebased on already accepted patches.
* Added mlx4 special QPs to the list of not-tracked QPs (dropped previous mlx4 special QP patch).
* Separated to two patches change in return value of cma_listen_* routines.
* Changed commit messages and added Fixes as Jason requested.
v2: https://lore.kernel.org/linux-rdma/20200907122156.478360-1-leon@kernel.org/
* Added new patch to fix mlx4 failure on SR-IOV, it didn't have port set.
* Changed "RDMA/cma: Delete from restrack DB after successful destroy" patch.
v1: https://lore.kernel.org/lkml/20200830101436.108487-1-leon@kernel.org
* Fixed rebase error, deleted second assignment of qp_type.
* Rebased code on latests rdma-next, the changes in cma.c caused to change
in patch "RDMA/cma: Delete from restrack DB after successful destroy".
* Dropped patch of port assignment, it is already done as part of this
series.
* I didn't add @calller description, regular users should not use _named() funciton.
v0: https://lore.kernel.org/lkml/20200824104415.1090901-1-leon@kernel.org
----------------------------------------------------------------------------------
Hi,
The resource tracker has built-in kref counter to synchronize object
release. It makes restrack perfect choice to be responsible for the
memory lifetime of any object in which restrack entry is embedded.
In order to make it, the restrack was changed to be mandatory and all
callers of rdma_restrack_add() started to rely on result returned from
that call. Being mandatory means that all objects specific to restrack
type must be tracked.
Before this series, the restrack and rdmatool were aid tools in debug
session of user space applications, this caused to some of the
functionality to be left behind, like support XRC QPs, device memory MRs
and QP0/QP1 in multi-port devices.
This series fixes all mentioned above without extending rdmatool at all.
Thanks
Leon Romanovsky (9):
RDMA/core: Allow drivers to disable restrack DB
RDMA/counter: Combine allocation and bind logic
RDMA/restrack: Store all special QPs in restrack DB
RDMA/cma: Add missing error handling of listen_id
RDMA/cma: Be strict with attaching to CMA device
RDMA/restrack: Add error handling while adding restrack object
RDMA/restrack: Support all QP types
RDMA/core: Track device memory MRs
RDMA/restrack: Drop valid restrack field as source of ambiguity
drivers/infiniband/core/cma.c | 226 +++++++++++-------
drivers/infiniband/core/core_priv.h | 32 ++-
drivers/infiniband/core/counters.c | 167 ++++++-------
drivers/infiniband/core/cq.c | 17 +-
drivers/infiniband/core/rdma_core.c | 3 +-
drivers/infiniband/core/restrack.c | 64 ++---
drivers/infiniband/core/restrack.h | 2 +-
drivers/infiniband/core/uverbs_cmd.c | 31 ++-
drivers/infiniband/core/uverbs_std_types_cq.c | 6 +-
drivers/infiniband/core/uverbs_std_types_mr.c | 10 +
drivers/infiniband/core/uverbs_std_types_qp.c | 4 +-
drivers/infiniband/core/verbs.c | 74 ++++--
drivers/infiniband/hw/mlx4/qp.c | 5 +
drivers/infiniband/hw/mlx5/qp.c | 2 +-
include/rdma/ib_verbs.h | 10 +-
include/rdma/restrack.h | 27 ++-
16 files changed, 416 insertions(+), 264 deletions(-)
--
2.26.2
reply other threads:[~2020-09-26 10:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200926101938.2964394-1-leon@kernel.org \
--to=leon@kernel.org \
--cc=dledford@redhat.com \
--cc=galpress@amazon.com \
--cc=jgg@nvidia.com \
--cc=lariel@mellanox.com \
--cc=leonro@mellanox.com \
--cc=leonro@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=markz@nvidia.com \
--cc=sean.hefty@intel.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).