On Fri, Sep 18, 2020 at 12:32:48AM +0200, Marek Behún wrote: > Hi, > > this series is also available at [1]. > > This is v2, you can read cover letter of v1 at [2] (togehter with > explanation of why I did this). > > Changes since v1: > - split big changes into several patches of little changes > - added many cosmetic fixes (helper variables, reversal christmas tree > variables declaration, ...) > - fixed some bugs in various drivers (memory leaks, iteration over > unavailable OF nodes) > - made some drivers compilable when COMPILE_TEST=y (since allyesconfig > did not compile them). Not all though, some still don't compile with > allyesconfig > - the commit that moves parsing of `linux,default-trigger` property from > drivers to LED core is now last in the series, instead of first > > Marek > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/kabel/linux.git/log/?h=leds-cleanup-for-pavel > [2] https://lore.kernel.org/linux-leds/20200916231650.11484-1-marek.behun@nic.cz/T/#m826493318174b0f38a3d4ba107092b5420ce440c ... > leds: ns2: use devres LED registering function > leds: ns2: alloc simple array instead of struct ns2_led_priv > leds: ns2: support OF probing only, forget platdata > leds: ns2: move parsing of one LED into separate function > leds: ns2: use devres API for getting GPIO descriptors > leds: ns2: cosmetic structure rename > leds: ns2: cosmetic variable rename > leds: ns2: cosmetic change > leds: ns2: cosmetic change: use helper variable > leds: ns2: register LED immediately after parsing DT properties > leds: ns2: remove unneeded variable > leds: ns2: cosmetic: use reverse christmas tree > leds: ns2: reorder headers alphabetically > leds: ns2: use struct led_init_data when registering > leds: parse linux,default-trigger DT property in LED core Hi Marek, For all the patches applying to the leds-ns2 driver: Reviewed-by: Simon Guinot Tested-by: Simon Guinot Thanks for it. The driver is looking way better. Simon