From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFB06C4741F for ; Mon, 28 Sep 2020 18:52:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7983F207D8 for ; Mon, 28 Sep 2020 18:52:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=rere.qmqm.pl header.i=@rere.qmqm.pl header.b="W1lG081J" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726667AbgI1Sw6 (ORCPT ); Mon, 28 Sep 2020 14:52:58 -0400 Received: from rere.qmqm.pl ([91.227.64.183]:18121 "EHLO rere.qmqm.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726460AbgI1Sw5 (ORCPT ); Mon, 28 Sep 2020 14:52:57 -0400 Received: from remote.user (localhost [127.0.0.1]) by rere.qmqm.pl (Postfix) with ESMTPSA id 4C0WqV6RpFz3c; Mon, 28 Sep 2020 20:52:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=rere.qmqm.pl; s=1; t=1601319175; bh=tRBvRQ9B3uw5joCA9ZCRpoEKWd6VUc0RpYzRqXVkJJo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=W1lG081JBniHBcrmTjVWaM8/+Qs0GuKcfhfgYwBa2UaCJMQdAR6lp3/wqwsJm0TTz /ODBo+YnWH9XvptmZP4pTov6m5EDiJHI1AS9Kh0ZKnrakB6COivieyopyzFbC/ih20 RlrRbsUHym/Vu4Pam1XofMQ5vIztHvRmBWD/V0a+rQevLO/Fr7Mgr7a3+Ig8oLDCOl hv0JOTTkzDhvSNh/BydKP25kho5t5L7ZdxP6ohu3YC4BhsVyY6mq3sXBBsQoHVDcEw w+eLzRq0Z6lahU7boMwzA0GcoYtkKgAOAwNecYKjCa02Elys2ztcOBNxl+sAYHlRpl fEDPyDo8zCuUg== X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.102.4 at mail Date: Mon, 28 Sep 2020 20:52:53 +0200 From: =?iso-8859-2?Q?Micha=B3_Miros=B3aw?= To: Thierry Reding Cc: Jaroslav Kysela , Takashi Iwai , Jonathan Hunter , Stephen Warren , alsa-devel@alsa-project.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: tegra20-spdif: remove "default m" Message-ID: <20200928185253.GB25616@qmqm.qmqm.pl> References: <20200928081026.GH2837573@ulmo> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200928081026.GH2837573@ulmo> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 28, 2020 at 10:10:26AM +0200, Thierry Reding wrote: > On Sat, Sep 26, 2020 at 09:42:40PM +0200, Michał Mirosław wrote: > > Make tegra20-spdif default to N as all other drivers do. > > > > Signed-off-by: Michał Mirosław > > Fixes: 774fec338bfc ("ASoC: Tegra: Implement SPDIF CPU DAI") > > I don't think this is warranted. This doesn't fix a bug or anything. > It's merely a change in the default configuration. The presence of a > Fixes: tag is typically used as a hint for people to pick this up into > stable releases, but I don't think this qualifies. [...] Fixes is just for pointing where the bug or issue originated. I usually include it to help you -- the reviewer -- and backporters if they ever want to use this patch. It is not specific to stable-directed patches. For stable candidates there is 'Cc: stable' tag (no need for this patch). > So now by default this driver will be disabled, which means that Linux > is going to regress for people that rely on this driver. The bug is that this driver (and only this driver in the whole sound/soc/tegra directory) defaults to m, where all other drivers default to n (as the policy aboud drivers seems to be [1]). This won't affect oldconfig, allyesconfig nor allmodconfig, but will not be selected now for clean builds - meaning less work for those not building for Tegra2. [1] https://lkml.org/lkml/2017/11/18/257 > You need to at least follow this up with a patch that makes the > corresponding change in both tegra_defconfig and multi_v7_defconfig to > ensure that this driver is going to get built by default. This I can do. Not all such drivers are enabled, though: eg. AHUB driver is not. Maybe we need bigger refresh of the defconfigs instead? > Given the above it's probably also a good idea to explain a bit more in > the commit message about what you're trying to achieve. Yes, "default n" > is usually the right thing to do and I'm honestly not sure why Stephen > chose to make this "default m" back in the day. Given that it depends on > SND_SOC_TEGRA, which itself is "default n", I think this makes some > sense, even if in retrospect it ended up being a bit inconsistent (you > could probably argue that all patches after this are the ones that were > inconsistent instead). This was merged over 9 years ago and a lot of > common practices have changed over that period of time. Yes, this is a cleanup. :-) Best Regards Michał Mirosław