From: Andrew Morton <akpm@linux-foundation.org>
To: Joonsoo Kim <js1304@gmail.com>
Cc: Linux Memory Management List <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Michal Hocko <mhocko@kernel.org>,
Vlastimil Babka <vbabka@suse.cz>,
"Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>,
Mel Gorman <mgorman@techsingularity.net>,
kernel-team@lge.com, Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [PATCH v2 for v5.9] mm/page_alloc: handle a missing case for memalloc_nocma_{save/restore} APIs
Date: Mon, 28 Sep 2020 21:50:55 -0700 [thread overview]
Message-ID: <20200928215055.02ff9b3ff5e0c392b2403411@linux-foundation.org> (raw)
In-Reply-To: <CAAmzW4OY7z+bF=aFOsNuadc8M_f1Pb7jifuxzQo5AL6mCuO5Ng@mail.gmail.com>
On Tue, 29 Sep 2020 10:28:05 +0900 Joonsoo Kim <js1304@gmail.com> wrote:
> > What about manually emptying the pcplists beforehand?
>
> It also increases the probability. schedule() or interrupt after emptying but
> before the allocation could invalidate the effect.
Keep local interrupts disabled across the pcp drain and the allocation
attempt.
> > Or byassing the pcplists for this caller and calling __rmqueue() directly?
>
> What this patch does is this one.
I meant via a different function rather than by adding overhead to the
existing commonly-used function.
next prev parent reply other threads:[~2020-09-29 4:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 8:50 [PATCH v2 for v5.9] mm/page_alloc: handle a missing case for memalloc_nocma_{save/restore} APIs js1304
2020-09-28 23:52 ` Andrew Morton
2020-09-29 1:28 ` Joonsoo Kim
2020-09-29 4:50 ` Andrew Morton [this message]
2020-09-29 6:46 ` Joonsoo Kim
2020-09-29 8:08 ` Michal Hocko
2020-09-29 8:38 ` Joonsoo Kim
2020-09-29 9:53 ` Michal Hocko
2020-09-29 8:13 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200928215055.02ff9b3ff5e0c392b2403411@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=js1304@gmail.com \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).