From: Alex Elder <elder@linaro.org>
To: davem@davemloft.net, kuba@kernel.org
Cc: evgreen@chromium.org, subashab@codeaurora.org,
cpratapa@codeaurora.org, bjorn.andersson@linaro.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH net-next 08/10] net: ipa: fix two mild warnings
Date: Mon, 28 Sep 2020 18:04:44 -0500 [thread overview]
Message-ID: <20200928230446.20561-9-elder@linaro.org> (raw)
In-Reply-To: <20200928230446.20561-1-elder@linaro.org>
Fix two spots where a variable "channel_id" is unnecessarily
redefined inside loops in "gsi.c". This is warned about if
"W=2" is added to the build command.
Note that this problem is harmless, so there's no need to backport
it as a bugfix.
Remove a comment in gsi_init() about waking the system; the GSI
interrupt does not wake the system any more.
Signed-off-by: Alex Elder <elder@linaro.org>
---
drivers/net/ipa/gsi.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ipa/gsi.c b/drivers/net/ipa/gsi.c
index cb676083dfa73..6bfac1efe037c 100644
--- a/drivers/net/ipa/gsi.c
+++ b/drivers/net/ipa/gsi.c
@@ -1600,7 +1600,7 @@ static int gsi_channel_setup(struct gsi *gsi, bool legacy)
/* Compute which modem channels need to be deallocated */
mask ^= gsi->modem_channel_bitmap;
while (mask) {
- u32 channel_id = __fls(mask);
+ channel_id = __fls(mask);
mask ^= BIT(channel_id);
@@ -1628,7 +1628,7 @@ static void gsi_channel_teardown(struct gsi *gsi)
mutex_lock(&gsi->mutex);
while (mask) {
- u32 channel_id = __fls(mask);
+ channel_id = __fls(mask);
mask ^= BIT(channel_id);
@@ -1972,7 +1972,6 @@ int gsi_init(struct gsi *gsi, struct platform_device *pdev, bool prefetch,
*/
init_dummy_netdev(&gsi->dummy_dev);
- /* Get the GSI IRQ and request for it to wake the system */
ret = platform_get_irq_byname(pdev, "gsi");
if (ret <= 0) {
dev_err(dev, "DT error %d getting \"gsi\" IRQ property\n", ret);
--
2.20.1
next prev parent reply other threads:[~2020-09-28 23:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 23:04 [PATCH net-next 00/10] net: ipa: miscellaneous cleanups Alex Elder
2020-09-28 23:04 ` [PATCH net-next 01/10] net: ipa: kill definition of TRE_FLAGS_IEOB_FMASK Alex Elder
2020-09-28 23:04 ` [PATCH net-next 02/10] net: ipa: kill unused status opcodes Alex Elder
2020-09-28 23:04 ` [PATCH net-next 03/10] net: ipa: kill unused status exceptions Alex Elder
2020-09-28 23:04 ` [PATCH net-next 04/10] net: ipa: remove unused status structure field masks Alex Elder
2020-09-28 23:04 ` [PATCH net-next 05/10] net: ipa: share field mask values for GSI interrupt type Alex Elder
2020-09-28 23:04 ` [PATCH net-next 06/10] net: ipa: share field mask values for GSI global interrupt Alex Elder
2020-09-28 23:04 ` [PATCH net-next 07/10] net: ipa: share field mask values for GSI general interrupt Alex Elder
2020-09-28 23:04 ` Alex Elder [this message]
2020-09-28 23:04 ` [PATCH net-next 09/10] net: ipa: rename a phandle variable Alex Elder
2020-09-28 23:04 ` [PATCH net-next 10/10] net: ipa: fix two comments Alex Elder
2020-09-29 1:35 ` [PATCH net-next 00/10] net: ipa: miscellaneous cleanups David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200928230446.20561-9-elder@linaro.org \
--to=elder@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=cpratapa@codeaurora.org \
--cc=davem@davemloft.net \
--cc=evgreen@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=subashab@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).