From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 071D4C2D0A8 for ; Mon, 28 Sep 2020 23:13:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D1ABB23A5B for ; Mon, 28 Sep 2020 23:13:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727010AbgI1XN3 (ORCPT ); Mon, 28 Sep 2020 19:13:29 -0400 Received: from mga14.intel.com ([192.55.52.115]:43207 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726984AbgI1XN2 (ORCPT ); Mon, 28 Sep 2020 19:13:28 -0400 IronPort-SDR: oOcRo+Z6RighYYP/VKtkCLsBqZNFJf5YUz6pvL2+BDKdYnOMi60eh6ylqfx2pR1VYg1+TurTli kurwS+PPh0dQ== X-IronPort-AV: E=McAfee;i="6000,8403,9758"; a="161305096" X-IronPort-AV: E=Sophos;i="5.77,315,1596524400"; d="scan'208";a="161305096" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2020 16:10:23 -0700 IronPort-SDR: jzzB2ktw+5o9UilhvKjWJ6uYd6yq1BpHpPLyEHNdX0M5ASEIiNL8oqeVQlfsxn+nq4yEki9aY6 sNlJlaGid8LQ== X-IronPort-AV: E=Sophos;i="5.77,315,1596524400"; d="scan'208";a="350003184" Received: from mdroper-desk1.fm.intel.com (HELO mdroper-desk1.amr.corp.intel.com) ([10.1.27.168]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2020 16:10:23 -0700 Date: Mon, 28 Sep 2020 16:10:22 -0700 From: Matt Roper To: Lucas De Marchi Cc: Jani Nikula , "Surendrakumar Upadhyay, TejaskumarX" , "Vivi, Rodrigo" , "airlied@linux.ie" , "daniel@ffwll.ch" , "intel-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "Ausmus, James" , "Souza, Jose" , "ville.syrjala@linux.intel.com" , "Pandey, Hariom" Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2 Message-ID: <20200928231022.GF2157395@mdroper-desk1.amr.corp.intel.com> References: <20200928080931.246347-1-tejaskumarx.surendrakumar.upadhyay@intel.com> <20200928080931.246347-3-tejaskumarx.surendrakumar.upadhyay@intel.com> <87a6xaow40.fsf@intel.com> <871rilq0um.fsf@intel.com> <20200928230739.vpj22bwebqhtehuk@ldmartin-desk1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200928230739.vpj22bwebqhtehuk@ldmartin-desk1> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 28, 2020 at 04:07:39PM -0700, Lucas De Marchi wrote: > On Mon, Sep 28, 2020 at 08:15:29PM +0300, Jani Nikula wrote: > > On Mon, 28 Sep 2020, "Surendrakumar Upadhyay, TejaskumarX" wrote: > > > This is a good example of a potential trap that having > > > IS_ELKHARTLAKE() cover both ELK and JSP creates. An unsuspecting coder > > > might change the if ladder to have IS_ELKHARTLAKE() first, and the > > > subsequent IS_JASPERLAKE() branch would never be taken. > > > > > > BR, > > > Jani. > > > > > > Tejas : In that case I will put attention note in comment about > > > platform checks such that ladder distrubance can be avoided. What you > > > suggest? > > > The solution is to make IS_ELKHARTLAKE() mean ELK and only ELK. > > Since we are talking about the TLA for JSL in the other patch, for > elkhartlake it is EHL, not ELK. ELK is something else, but I'm not sure > what: > > $ git grep -w ELK -- drivers/gpu/drm/ > drivers/gpu/drm/i915/gem/i915_gem_stolen.c: IS_GM45(i915) ? "CTG" : "ELK", reg_val); > drivers/gpu/drm/i915/gem/i915_gem_stolen.c: * Whether ILK really reuses the ELK register for this is unclear. > drivers/gpu/drm/i915/intel_pm.c: * Not 100% sure which way ELK should go here as the > drivers/gpu/drm/i915/intel_pm.c: * assume ELK doesn't need this. Yeah, ELK = Eagle Lake, CTG = Cantiga. Both are old gen5 platforms IIRC. Matt > > Lucas De Marchi > > > > > BR, > > Jani. > > > > > > -- > > Jani Nikula, Intel Open Source Graphics Center -- Matt Roper Graphics Software Engineer VTT-OSGC Platform Enablement Intel Corporation (916) 356-2795