From: Peter Zijlstra <peterz@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: quanyang.wang@windriver.com, linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Leo Yan <leo.yan@linaro.org>, Will Deacon <will@kernel.org>,
a.darwish@linutronix.de,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Paul Cercueil <paul@crapouillou.net>,
Randy Dunlap <rdunlap@infradead.org>,
ben.dooks@codethink.co.uk
Subject: Re: [PATCH] time/sched_clock: mark sched_clock_read_begin as notrace
Date: Tue, 29 Sep 2020 09:13:33 +0200 [thread overview]
Message-ID: <20200929071333.GK2628@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20200928173331.3ea3cfb7@oasis.local.home>
On Mon, Sep 28, 2020 at 05:33:31PM -0400, Steven Rostedt wrote:
> On Mon, 28 Sep 2020 12:58:59 +0200
> Peter Zijlstra <peterz@infradead.org> wrote:
>
> > > -struct clock_read_data *sched_clock_read_begin(unsigned int *seq)
> > > +notrace struct clock_read_data *sched_clock_read_begin(unsigned int *seq)
> > > {
> > > *seq = raw_read_seqcount_latch(&cd.seq);
> > > return cd.read_data + (*seq & 1);
> >
> > At the very least sched_clock_read_retry() should also be marked such.
> >
> > But Steve, how come x86 works? Our sched_clock() doesn't have notrace on
> > at all.
>
> It's because of that magic in the Makefile that you love so much ;-)
>
> CFLAGS_REMOVE_tsc.o = -pg
ARGH!!, I really should write a script to fix up that mess :/
next prev parent reply other threads:[~2020-09-29 7:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 10:49 [PATCH] time/sched_clock: mark sched_clock_read_begin as notrace quanyang.wang
2020-09-28 10:58 ` Peter Zijlstra
2020-09-28 12:41 ` Quanyang Wang
2020-09-28 21:33 ` Steven Rostedt
2020-09-29 7:13 ` Peter Zijlstra [this message]
2020-09-29 14:43 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929071333.GK2628@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=a.darwish@linutronix.de \
--cc=ben.dooks@codethink.co.uk \
--cc=daniel.lezcano@linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=quanyang.wang@windriver.com \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).