From: Eli Cohen <elic@nvidia.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: <jasowang@redhat.com>,
<virtualization@lists.linux-foundation.org>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<elic@nvidia.com>
Subject: Re: [PATCH V1 vhost-next] vdpa/mlx5: Make vdpa core driver a distinct module
Date: Tue, 29 Sep 2020 10:42:48 +0300 [thread overview]
Message-ID: <20200929074248.GA123696@mtl-vdi-166.wap.labs.mlnx> (raw)
In-Reply-To: <20200929031348-mutt-send-email-mst@kernel.org>
On Tue, Sep 29, 2020 at 03:17:05AM -0400, Michael S. Tsirkin wrote:
> >
> > Use "select MLX5_CORE"
> > instead of "depends on MLX5_CORE"
> >
> > Wasn't this agreed upon?
>
> Hmm I don't know. I recall a similar discussion around VHOST_IOTLB.
> That's different ...
I see.
>
> I see
>
> [linux]$ git grep MLX5_CORE|grep depends
> drivers/infiniband/hw/mlx5/Kconfig: depends on NETDEVICES && ETHERNET && PCI && MLX5_CORE
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig: depends on MLX5_CORE
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig: depends on NETDEVICES && ETHERNET && INET && PCI && MLX5_CORE
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig: depends on MLX5_CORE_EN && RFS_ACCEL
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig: depends on MLX5_CORE_EN
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig: depends on MLX5_CORE_EN
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig: depends on MLX5_CORE_EN && NET_SWITCHDEV
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig: depends on MLX5_CORE_EN && DCB
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig: depends on MLX5_CORE_EN
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig: depends on MLX5_CORE
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig: depends on MLX5_CORE_EN
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig: depends on MLX5_CORE_EN
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig: depends on TLS=y || MLX5_CORE=m
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig: depends on MLX5_CORE_EN
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig: depends on TLS=y || MLX5_CORE=m
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig: depends on MLX5_CORE_EN
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig: depends on MLX5_CORE_EN && MLX5_ESWITCH
> drivers/vdpa/Kconfig: depends on MLX5_CORE
>
> and no selects of this symbol, I guess you are saying you are changing everything
> else to select - is that right? Then I guess vdpa should follow suit ...
>
No, I will leave that and will discuss internally if/who/when will do
this.
prev parent reply other threads:[~2020-09-29 7:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 14:32 [PATCH V1 vhost-next] vdpa/mlx5: Make vdpa core driver a distinct module Eli Cohen
2020-09-28 19:55 ` Michael S. Tsirkin
2020-09-29 6:20 ` Eli Cohen
2020-09-29 6:26 ` Michael S. Tsirkin
2020-09-29 6:34 ` Eli Cohen
2020-09-29 6:51 ` Michael S. Tsirkin
2020-09-29 6:57 ` Eli Cohen
2020-09-29 7:17 ` Michael S. Tsirkin
2020-09-29 7:42 ` Eli Cohen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929074248.GA123696@mtl-vdi-166.wap.labs.mlnx \
--to=elic@nvidia.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).