From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Paul McKenney <paulmck@kernel.org>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>,
kim.phillips@amd.com
Subject: Re: [PATCH] rcu,ftrace: Fix ftrace recursion
Date: Tue, 29 Sep 2020 11:19:03 -0400 [thread overview]
Message-ID: <20200929111903.3e3e8c23@gandalf.local.home> (raw)
In-Reply-To: <20200929144953.GP2628@hirez.programming.kicks-ass.net>
On Tue, 29 Sep 2020 16:49:53 +0200
Peter Zijlstra <peterz@infradead.org> wrote:
> On Tue, Sep 29, 2020 at 10:36:20AM -0400, Steven Rostedt wrote:
>
> > > +notrace bool rcu_is_watching(void)
> > > {
> > > bool ret;
> > >
> >
> > I think the patch I suggested is more suitable.
>
> Both, with only your patch we'd still take the pointless mcount call,
> which is then pure overhead.
Yep, and I stated the same thing to Paul ;-)
-- Steve
next prev parent reply other threads:[~2020-09-29 15:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 11:33 [PATCH] rcu,ftrace: Fix ftrace recursion Peter Zijlstra
2020-09-29 14:31 ` Paul E. McKenney
2020-09-29 14:36 ` Steven Rostedt
2020-09-29 14:41 ` Paul E. McKenney
2020-09-29 14:54 ` Steven Rostedt
2020-09-29 16:56 ` Paul E. McKenney
2020-09-29 17:04 ` Steven Rostedt
2020-10-05 0:18 ` Paul E. McKenney
2020-09-29 14:49 ` Peter Zijlstra
2020-09-29 15:19 ` Steven Rostedt [this message]
2020-09-29 14:43 ` Kim Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929111903.3e3e8c23@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=kim.phillips@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).