From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 050FFC4741F for ; Tue, 29 Sep 2020 11:39:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9A27A2074A for ; Tue, 29 Sep 2020 11:39:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="HK07rgT4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729393AbgI2LjG (ORCPT ); Tue, 29 Sep 2020 07:39:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730397AbgI2Lim (ORCPT ); Tue, 29 Sep 2020 07:38:42 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8196C0613D8; Tue, 29 Sep 2020 04:25:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=K45FSWL81eUOoatztmQCrTr+UOCs2bFaxc8jCxV4h2E=; b=HK07rgT4+5Xu5gL+tL9A4tn0IX jM/ADvK5/oWNeuIXWU6K3RnIhY1vuwBSueK1WwfthV5heHww/NJsh1rinbYDUQTfmKRXD6AP8bVMM oC9V/0T+D1iN2RlSzD6wtSt89XdsDwrdhoAgA7gPvwcYtBS/vBc8RBaxMVEtwEmKvpJorFPO8OkRA a07/liEG3nYca9WlxLdpt8QTFUZHQujS9iXhQDYov+4sdugMzqZ72zMEdoHVThEp43Zn8I2LJ0Tt9 ngXca3KC3HfXLxSUpxtvVr02ipy7mqscBjSES6aQKIG04GA5hoRi6qhkKXIl9vIpsAgp0r9NLPScv 63bFPlQA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNDlQ-0006ot-G3; Tue, 29 Sep 2020 11:25:44 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id E32AB30753E; Tue, 29 Sep 2020 13:25:41 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id B392D200D4C4A; Tue, 29 Sep 2020 13:25:41 +0200 (CEST) Date: Tue, 29 Sep 2020 13:25:41 +0200 From: Peter Zijlstra To: linux-kernel@vger.kernel.org Cc: linux-tip-commits@vger.kernel.org, Thomas Gleixner , Alexandre Chartre , "Paul E. McKenney" , x86 , Steven Rostedt Subject: Re: [tip: core/rcu] rcu/tree: Mark the idle relevant functions noinstr Message-ID: <20200929112541.GM2628@hirez.programming.kicks-ass.net> References: <20200505134100.575356107@linutronix.de> <158991795300.17951.11897222265664137612.tip-bot2@tip-bot2> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <158991795300.17951.11897222265664137612.tip-bot2@tip-bot2> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 19, 2020 at 07:52:33PM -0000, tip-bot2 for Thomas Gleixner wrote: > @@ -979,7 +988,7 @@ static void rcu_disable_urgency_upon_qs(struct rcu_data *rdp) > * if the current CPU is not in its idle loop or is in an interrupt or > * NMI handler, return true. > */ > -bool notrace rcu_is_watching(void) > +bool rcu_is_watching(void) > { > bool ret; > This ^.. it is required because __ftrace_ops_list_func() / ftrace_ops_assist_func() call it outside of ftrace recursion, but only when FL_RCU, and perf happens to be the only user of that. another morning wasted... :/