From: Jonathan Cameron <jic23@kernel.org>
To: Cristian Pop <cristian.pop@analog.com>
Cc: <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v7 4/5] dt-bindings:iio:adc:adi,ad7768-1: Add documentation for channel label
Date: Tue, 29 Sep 2020 16:48:21 +0100 [thread overview]
Message-ID: <20200929164821.49f83061@archlinux> (raw)
In-Reply-To: <20200928090959.88842-4-cristian.pop@analog.com>
On Mon, 28 Sep 2020 12:09:58 +0300
Cristian Pop <cristian.pop@analog.com> wrote:
> Optional attribute for better identification of the channels.
>
> Signed-off-by: Cristian Pop <cristian.pop@analog.com>
Dt-bindings should be cc'd to Rob + the dt list.
+CC
> ---
> Changes in v7:
> - Add "additionalProperties: false" for channel child nodes.
> - Fix "reg" spelling.
> .../bindings/iio/adc/adi,ad7768-1.yaml | 32 +++++++++++++++++++
> 1 file changed, 32 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7768-1.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7768-1.yaml
> index d3733ad8785a..6be43bf5c1e0 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7768-1.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7768-1.yaml
> @@ -29,6 +29,12 @@ properties:
> interrupts:
> maxItems: 1
>
> + '#address-cells':
> + const: 1
> +
> + '#size-cells':
> + const: 0
> +
> vref-supply:
> description:
> ADC reference voltage supply
> @@ -61,6 +67,24 @@ required:
> - spi-cpha
> - adi,sync-in-gpios
>
> +patternProperties:
> + "^channel@([0-9]|1[0-5])$":
> + type: object
> + description: |
> + Represents the external channels which are connected to the device.
> +
> + properties:
> + reg:
> + description: |
> + The channel number.
> +
> + label:
> + description: |
> + Unique name to identify which channel this is.
> + required:
> + - reg
> + additionalProperties: false
> +
> additionalProperties: false
>
> examples:
> @@ -84,6 +108,14 @@ examples:
> reset-gpios = <&gpio 27 GPIO_ACTIVE_LOW>;
> clocks = <&ad7768_mclk>;
> clock-names = "mclk";
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + channel@0 {
> + reg = <0>;
> + label = "channel_0";
> + };
> };
> };
> ...
next prev parent reply other threads:[~2020-09-29 15:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 9:09 [PATCH v7 1/5] iio: core: Add optional symbolic label to a device channel Cristian Pop
2020-09-28 9:09 ` [PATCH v7 2/5] iio:Documentation: Add documentation for label channel attribute Cristian Pop
2020-09-28 9:09 ` [PATCH v7 3/5] iio: adc: ad7768-1: Add channel labels Cristian Pop
2020-09-28 9:09 ` [PATCH v7 4/5] dt-bindings:iio:adc:adi,ad7768-1: Add documentation for channel label Cristian Pop
2020-09-29 15:48 ` Jonathan Cameron [this message]
2020-09-28 9:09 ` [PATCH v7 5/5] dt-bindings:iio:adc:adc.txt: Add documentation for channel label attribute Cristian Pop
2020-09-29 15:48 ` Jonathan Cameron
2020-11-01 15:38 ` [PATCH v7 1/5] iio: core: Add optional symbolic label to a device channel Jonathan Cameron
2020-11-08 16:08 ` Jonathan Cameron
2020-11-02 14:16 Cristian Pop
2020-11-02 14:16 ` [PATCH v7 4/5] dt-bindings:iio:adc:adi,ad7768-1: Add documentation for channel label Cristian Pop
2020-11-02 14:19 [PATCH v7 1/5] iio: core: Add optional symbolic label to a device channel Cristian Pop
2020-11-02 14:19 ` [PATCH v7 4/5] dt-bindings:iio:adc:adi,ad7768-1: Add documentation for channel label Cristian Pop
2020-11-05 17:19 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929164821.49f83061@archlinux \
--to=jic23@kernel.org \
--cc=cristian.pop@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).