From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: gregkh@linuxfoundation.org
Cc: hemantk@codeaurora.org, bbhatt@codeaurora.org,
linux-arm-msm@vger.kernel.org, jhugo@codeaurora.org,
linux-kernel@vger.kernel.org,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: [PATCH v3 10/19] bus: mhi: core: Introduce APIs to allocate and free the MHI controller
Date: Tue, 29 Sep 2020 23:22:09 +0530 [thread overview]
Message-ID: <20200929175218.8178-11-manivannan.sadhasivam@linaro.org> (raw)
In-Reply-To: <20200929175218.8178-1-manivannan.sadhasivam@linaro.org>
From: Bhaumik Bhatt <bbhatt@codeaurora.org>
Client devices should use the APIs provided to allocate and free
the MHI controller structure. This will help ensure that the
structure is zero-initialized and there are no false positives
with respect to reading any values such as the serial number or
the OEM PK hash.
Suggested-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
drivers/bus/mhi/core/init.c | 16 ++++++++++++++++
include/linux/mhi.h | 12 ++++++++++++
2 files changed, 28 insertions(+)
diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c
index e2011ec46b92..f69a2f3d039d 100644
--- a/drivers/bus/mhi/core/init.c
+++ b/drivers/bus/mhi/core/init.c
@@ -954,6 +954,22 @@ void mhi_unregister_controller(struct mhi_controller *mhi_cntrl)
}
EXPORT_SYMBOL_GPL(mhi_unregister_controller);
+struct mhi_controller *mhi_alloc_controller(void)
+{
+ struct mhi_controller *mhi_cntrl;
+
+ mhi_cntrl = kzalloc(sizeof(*mhi_cntrl), GFP_KERNEL);
+
+ return mhi_cntrl;
+}
+EXPORT_SYMBOL_GPL(mhi_alloc_controller);
+
+void mhi_free_controller(struct mhi_controller *mhi_cntrl)
+{
+ kfree(mhi_cntrl);
+}
+EXPORT_SYMBOL_GPL(mhi_free_controller);
+
int mhi_prepare_for_power_up(struct mhi_controller *mhi_cntrl)
{
struct device *dev = &mhi_cntrl->mhi_dev->dev;
diff --git a/include/linux/mhi.h b/include/linux/mhi.h
index 0c97f4bc5fae..6b987e8cc438 100644
--- a/include/linux/mhi.h
+++ b/include/linux/mhi.h
@@ -527,6 +527,18 @@ struct mhi_driver {
#define to_mhi_driver(drv) container_of(drv, struct mhi_driver, driver)
#define to_mhi_device(dev) container_of(dev, struct mhi_device, dev)
+/**
+ * mhi_alloc_controller - Allocate the MHI Controller structure
+ * Allocate the mhi_controller structure using zero initialized memory
+ */
+struct mhi_controller *mhi_alloc_controller(void);
+
+/**
+ * mhi_free_controller - Free the MHI Controller structure
+ * Free the mhi_controller structure which was previously allocated
+ */
+void mhi_free_controller(struct mhi_controller *mhi_cntrl);
+
/**
* mhi_register_controller - Register MHI controller
* @mhi_cntrl: MHI controller to register
--
2.17.1
next prev parent reply other threads:[~2020-09-29 17:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 17:51 [PATCH v3 00/19] MHI changes for v5.10 Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 01/19] bus: mhi: fix doubled words and struct image_info kernel-doc Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 02/19] bus: mhi: core: Remove double occurrence for mhi_ctrl_ev_task() declaration Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 03/19] bus: mhi: core: Abort suspends due to outgoing pending packets Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 04/19] bus: mhi: core: Use helper API to trigger a non-blocking host resume Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 05/19] bus: mhi: core: Trigger host resume if suspended during mhi_device_get() Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 06/19] bus: mhi: core: Use generic name field for an MHI device Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 07/19] bus: mhi: core: Introduce helper function to check device state Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 08/19] bus: mhi: core: Introduce counters to track MHI device state transitions Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 09/19] bus: mhi: core: Read and save device hardware information from BHI Manivannan Sadhasivam
2020-09-29 17:52 ` Manivannan Sadhasivam [this message]
2020-09-29 17:52 ` [PATCH v3 11/19] bus: mhi: core: Add const qualifier to MHI config information Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 12/19] bus: mhi: Remove include of rwlock_types.h Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 13/19] bus: mhi: Fix entries based on Kconfig coding style Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 14/19] bus: mhi: core: Introduce debugfs entries for MHI Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 15/19] bus: mhi: core: Introduce sysfs " Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 16/19] bus: mhi: core: Allow shared IRQ for event rings Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 17/19] bus: mhi: Remove unused nr_irqs_req variable Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 18/19] bus: mhi: core: Fix the building of MHI module Manivannan Sadhasivam
2020-09-29 17:52 ` [PATCH v3 19/19] bus: mhi: debugfs: Print channel context read-pointer Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929175218.8178-11-manivannan.sadhasivam@linaro.org \
--to=manivannan.sadhasivam@linaro.org \
--cc=bbhatt@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=hemantk@codeaurora.org \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).